Issue metadata
Sign in to add a comment
|
Telemetry: run_benchmark failing to set command line args |
||||||||||||||||||||||||
Issue descriptionMy userdebug android image had the following chrome-command-line file in /data/local and /data/local/tmp: chrome --disable-fre --disable-popup-blocking --enable-remote-debugging --ignore-certificate-errors --metrics-recording-only This was causing empty output when running benchmarks but the only indication of failure was this warning, which wasn't very helpful: WARNING:root:Exception was raised in the with statement block, the end of interaction record is not marked. Digging through verbose logs revealed that the browser didn't support gpuBenchmarking so the command line flags telemetry passes weren't effective. This took quite a while to find so either there should be an explicit message for when we fail to apply the command line or the run_benchmark script needs to be able to handle an existing chrome-command-line file.
,
Oct 5 2016
Yes, but it's not a publicly exposed API so you need to run with the --enable-gpu-benchmarking flag, which run_benchmark should do but was failing because of the existing flags file. The chrome is ToT, version is 55.0.2881.0 and Android 6.0.1
,
Oct 5 2016
IIRC, telemetry should override the existing flag file: https://github.com/catapult-project/catapult/blob/57d0dc443b723f6bf96231c7fbbff8e0ff55aa2c/telemetry/telemetry/internal/backends/android_command_line_backend.py#L34 I suspect what happened here is Telemetry may try setting up the flag file as the wrong location.
,
Oct 5 2016
Yes, I think the problem is having command line files in both /data/local and /data/local/tmp (Chrome will pick up the later, but Telemetry will write to the former). The solution is just to remove both of those files before trying to run Telemetry. On issue 640228 I'll work to have a fix for this from the Telemetry side.
,
Oct 5 2016
,
Oct 5 2016
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by nedngu...@google.com
, Oct 5 2016