New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 652698 link

Starred by 1 user
Status: Verified
Owner:
mlamouri@chromium.org
Closed: Oct 2016
Cc:
█ rachelis@chromium.org
█ renganat...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Tapping on a video to show controls shouldn't trigger the controls action

Project Member Reported by mlamouri@chromium.org, Oct 4 2016 
STR:
- Open https://mounirlamouri.github.io/sandbox/media/dynamic-controls.html
- Start video
- Look at where the pause button is
- Wait for the pause button to disappear
- Tap where the pause button was

Expected result: controls are visible again
Actual result: video is paused and controls are visible again

Comment 1 by renganat...@chromium.org, Oct 7 2016

Labels: Hotlist-Polish

Comment 2 by mlamouri@chromium.org, Oct 18 2016

Owner: mlamouri@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb55961999ccce51568d3fcdfbb51c8ba5bcfdb2

commit cb55961999ccce51568d3fcdfbb51c8ba5bcfdb2
Author: mlamouri <mlamouri@chromium.org>
Date: Thu Oct 20 11:53:30 2016

Media Controls: don't activate buttons when tapping on hidden controls.

This should also fix an accessibility issue where activating the
controls while hidden would randomly activate one of the buttons.

BUG=654648, 652698 

Review-Url: https://chromiumcodereview.appspot.com/2431583004
Cr-Commit-Position: refs/heads/master@{#426452}

[add] https://crrev.com/cb55961999ccce51568d3fcdfbb51c8ba5bcfdb2/third_party/WebKit/LayoutTests/media/media-controls-tap-show-controls-without-activating.html
[modify] https://crrev.com/cb55961999ccce51568d3fcdfbb51c8ba5bcfdb2/third_party/WebKit/LayoutTests/media/media-controls.js
[modify] https://crrev.com/cb55961999ccce51568d3fcdfbb51c8ba5bcfdb2/third_party/WebKit/LayoutTests/media/video-controls-visibility-multimodal-mouse-after-touch.html
[modify] https://crrev.com/cb55961999ccce51568d3fcdfbb51c8ba5bcfdb2/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
[modify] https://crrev.com/cb55961999ccce51568d3fcdfbb51c8ba5bcfdb2/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
[modify] https://crrev.com/cb55961999ccce51568d3fcdfbb51c8ba5bcfdb2/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
[modify] https://crrev.com/cb55961999ccce51568d3fcdfbb51c8ba5bcfdb2/third_party/WebKit/Source/core/html/shadow/MediaControls.h

Comment 4 by mlamouri@chromium.org, Oct 20 2016

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 25 2016

Labels: merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20108d0c66bf5aa78246c7d18b9cf1e57adb81e7

commit 20108d0c66bf5aa78246c7d18b9cf1e57adb81e7
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Tue Oct 25 12:36:35 2016

Media Controls: don't activate buttons when tapping on hidden controls.

This should also fix an accessibility issue where activating the
controls while hidden would randomly activate one of the buttons.

BUG=654648, 652698 

Review-Url: https://chromiumcodereview.appspot.com/2431583004
Cr-Commit-Position: refs/heads/master@{#426452}
(cherry picked from commit cb55961999ccce51568d3fcdfbb51c8ba5bcfdb2)

Review URL: https://codereview.chromium.org/2451653003 .

Cr-Commit-Position: refs/branch-heads/2883@{#277}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[add] https://crrev.com/20108d0c66bf5aa78246c7d18b9cf1e57adb81e7/third_party/WebKit/LayoutTests/media/media-controls-tap-show-controls-without-activating.html
[modify] https://crrev.com/20108d0c66bf5aa78246c7d18b9cf1e57adb81e7/third_party/WebKit/LayoutTests/media/media-controls.js
[modify] https://crrev.com/20108d0c66bf5aa78246c7d18b9cf1e57adb81e7/third_party/WebKit/LayoutTests/media/video-controls-visibility-multimodal-mouse-after-touch.html
[modify] https://crrev.com/20108d0c66bf5aa78246c7d18b9cf1e57adb81e7/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
[modify] https://crrev.com/20108d0c66bf5aa78246c7d18b9cf1e57adb81e7/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
[modify] https://crrev.com/20108d0c66bf5aa78246c7d18b9cf1e57adb81e7/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
[modify] https://crrev.com/20108d0c66bf5aa78246c7d18b9cf1e57adb81e7/third_party/WebKit/Source/core/html/shadow/MediaControls.h

Comment 6 by arunshan@chromium.org, Oct 26 2016

Status: Verified (was: Fixed)
This issue is fixed in current M55 build 55.0.2883.28. Tapping on where the pause button was after the video controls disappears, video does not pause and controls are visible again.
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20108d0c66bf5aa78246c7d18b9cf1e57adb81e7

commit 20108d0c66bf5aa78246c7d18b9cf1e57adb81e7
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Tue Oct 25 12:36:35 2016

Media Controls: don't activate buttons when tapping on hidden controls.

This should also fix an accessibility issue where activating the
controls while hidden would randomly activate one of the buttons.

BUG=654648, 652698 

Review-Url: https://chromiumcodereview.appspot.com/2431583004
Cr-Commit-Position: refs/heads/master@{#426452}
(cherry picked from commit cb55961999ccce51568d3fcdfbb51c8ba5bcfdb2)

Review URL: https://codereview.chromium.org/2451653003 .

Cr-Commit-Position: refs/branch-heads/2883@{#277}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[add] https://crrev.com/20108d0c66bf5aa78246c7d18b9cf1e57adb81e7/third_party/WebKit/LayoutTests/media/media-controls-tap-show-controls-without-activating.html
[modify] https://crrev.com/20108d0c66bf5aa78246c7d18b9cf1e57adb81e7/third_party/WebKit/LayoutTests/media/media-controls.js
[modify] https://crrev.com/20108d0c66bf5aa78246c7d18b9cf1e57adb81e7/third_party/WebKit/LayoutTests/media/video-controls-visibility-multimodal-mouse-after-touch.html
[modify] https://crrev.com/20108d0c66bf5aa78246c7d18b9cf1e57adb81e7/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
[modify] https://crrev.com/20108d0c66bf5aa78246c7d18b9cf1e57adb81e7/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
[modify] https://crrev.com/20108d0c66bf5aa78246c7d18b9cf1e57adb81e7/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
[modify] https://crrev.com/20108d0c66bf5aa78246c7d18b9cf1e57adb81e7/third_party/WebKit/Source/core/html/shadow/MediaControls.h

Comment 8 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
►

Sign in to add a comment