Issue metadata
Sign in to add a comment
|
Update ChromeVox spoken feedback for Bluetooth ToggleButton |
||||||||||||||||||||||||
Issue descriptionCurrently the ChromeVox spoken feedback for ToggleButton is just "Button". This needs to be more descriptive, e.g. something like "Enable Bluetooth, toggle, not toggled".
,
Oct 4 2016
for the "enable bluetooth" part, whoever instantiates a ToggleButton needs to call SetAccessibleName() on it. It seems like "Enable Bluetooth, button" and "Disable Bluetooth, button" are good descriptors (I don't think the "pressed"/"not pressed" part of what we currently have makes much sense).
,
Nov 1 2016
fukino@, can you please take a look into making this change?
,
Nov 1 2016
,
Nov 2 2016
I do think we should keep the same pattern. The "pressed" part is relevant because it helps the user know the state of the toggle --whether it's pressed or not (instead of just a button that they don't know if they need to press again to get the result they want). Make sense?
,
Nov 2 2016
"Enable Bluetooth, button" and "Disable Bluetooth, button" don't seem ambiguous, but anyway I don't think "pressed" is the greatest because the button isn't pressed in the normal sense (i.e. currently being clicked). "on" vs "off" would be better. I don't know what to call the control though. Conceptually, it's identical to a checkbox. Should we call it one? Should we call it a "Switch", will users make the connection to a light switch? I don't like "toggle" because that sounds jargony and verby.
,
Nov 3 2016
TalkBack on Android refers to these toggles as "on switch" and "off switch" depending on the state. I think it makes sense to stay consistent with that, unless there are any concerns?
,
Nov 3 2016
I'm fine with Tom's proposal in #7. I wasn't tied to the "pressed" language -- I just want to make sure the state is somehow reflected clearly to the user.
,
Nov 3 2016
great -- what's the final spoken string? "Bluetooth, on switch" vs "Bluetooth, off switch"?
,
Nov 3 2016
Re #9, I tried out TalkBack and yes that is the format of the spoken string used.
,
Nov 4 2016
I have a CL to improve (hopefully!) chromevox here: https://codereview.chromium.org/2472303002/ we'll see what Dominic thinks.
,
Nov 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4f55d095b7e0fd782ffe6501ff13d043ef2c4bc commit c4f55d095b7e0fd782ffe6501ff13d043ef2c4bc Author: estade <estade@chromium.org> Date: Fri Nov 04 17:13:13 2016 Add/improve ChromeVox feedback for switches e.g. "Enable Wi-Fi, switch on" or "Enable Wi-Fi, switch off". BUG= 652677 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2472303002 Cr-Commit-Position: refs/heads/master@{#429924} [modify] https://crrev.com/c4f55d095b7e0fd782ffe6501ff13d043ef2c4bc/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js [modify] https://crrev.com/c4f55d095b7e0fd782ffe6501ff13d043ef2c4bc/chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd
,
Nov 4 2016
fukino@, for other toggles in the system menu we're setting accessible text but no tooltip for mouse hover. So please use toggle->SetAccessibleName() instead of toggle->SetTooltipText(). This sets the spoken feedback, and you should get the "on/off" for free from #12.
,
Nov 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48df76a8d587632d3c83119b6be669c2a222b4a4 commit 48df76a8d587632d3c83119b6be669c2a222b4a4 Author: estade <estade@chromium.org> Date: Fri Nov 04 20:14:48 2016 Improve a11y state for ToggleButton. Also add a description for the wifi toggle button instance. BUG= 652677 Review-Url: https://codereview.chromium.org/2477983003 Cr-Commit-Position: refs/heads/master@{#429992} [modify] https://crrev.com/48df76a8d587632d3c83119b6be669c2a222b4a4/ash/common/system/chromeos/network/network_list_md.cc [modify] https://crrev.com/48df76a8d587632d3c83119b6be669c2a222b4a4/ui/views/controls/button/toggle_button.cc [modify] https://crrev.com/48df76a8d587632d3c83119b6be669c2a222b4a4/ui/views/controls/button/toggle_button.h
,
Nov 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/974c67a70351cf6b243833b309996046fdcab1f5 commit 974c67a70351cf6b243833b309996046fdcab1f5 Author: azurewei <azurewei@chromium.org> Date: Sun Nov 06 05:23:13 2016 [ash-md] Add on-screen keyboard toggle row in IME menu view. 1. Add vector icons ime_menu_on_screen_keyboard.*.icon for on-screen keyboard. 2. Add new class MaterialKeyboardStatusRowView in ImeListView to show the keyboard row: a on-screen keyboard, a label and a toggle button. 3. Makes s shown only for MD and sticky when scrolling. 4. Updates the ImeInfoView as simple Label+Label+Image with TriView. And updates the id size. * Still needs follow-up CL to make MaterialKeyboardStatusRowView has shadow and shown in opt-in IME menu. BUG=657146, 642385, 652677 TEST=Verified on local build. Review-Url: https://codereview.chromium.org/2469663002 Cr-Commit-Position: refs/heads/master@{#430186} [modify] https://crrev.com/974c67a70351cf6b243833b309996046fdcab1f5/ash/common/system/chromeos/ime_menu/ime_list_view.cc [modify] https://crrev.com/974c67a70351cf6b243833b309996046fdcab1f5/ash/common/system/chromeos/ime_menu/ime_list_view.h [modify] https://crrev.com/974c67a70351cf6b243833b309996046fdcab1f5/ash/common/system/ime/tray_ime_chromeos_unittest.cc [modify] https://crrev.com/974c67a70351cf6b243833b309996046fdcab1f5/ash/resources/vector_icons/BUILD.gn [add] https://crrev.com/974c67a70351cf6b243833b309996046fdcab1f5/ash/resources/vector_icons/ime_menu_on_screen_keyboard.1x.icon [add] https://crrev.com/974c67a70351cf6b243833b309996046fdcab1f5/ash/resources/vector_icons/ime_menu_on_screen_keyboard.icon
,
Nov 14 2016
,
Nov 14 2016
,
Nov 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0cd6680fbb8a4562fdb047618233b2482f6225c commit f0cd6680fbb8a4562fdb047618233b2482f6225c Author: tdanderson <tdanderson@chromium.org> Date: Wed Nov 16 18:40:15 2016 Modify Ash MD system menu layout for title rows Correct the layout for the detailed view title rows in the Ash material design system menu. This is done by making use of TriView (as is used in many other places in the system menu for uniformity) and making SpecialPopupRow only used in non-MD. Furthermore, this CL corrects the base spoken feedback name used for all toggles in the system menu (Bluetooth, WiFi/cellular, and IME VK). BUG=663050, 652677 ,661319 TEST=ash_unittests Review-Url: https://codereview.chromium.org/2497813002 Cr-Commit-Position: refs/heads/master@{#432569} [modify] https://crrev.com/f0cd6680fbb8a4562fdb047618233b2482f6225c/ash/common/system/chromeos/bluetooth/tray_bluetooth.cc [modify] https://crrev.com/f0cd6680fbb8a4562fdb047618233b2482f6225c/ash/common/system/chromeos/ime_menu/ime_list_view.cc [modify] https://crrev.com/f0cd6680fbb8a4562fdb047618233b2482f6225c/ash/common/system/chromeos/network/network_list_md.cc [modify] https://crrev.com/f0cd6680fbb8a4562fdb047618233b2482f6225c/ash/common/system/chromeos/network/network_state_list_detailed_view.cc [modify] https://crrev.com/f0cd6680fbb8a4562fdb047618233b2482f6225c/ash/common/system/ime/tray_ime_chromeos.cc [modify] https://crrev.com/f0cd6680fbb8a4562fdb047618233b2482f6225c/ash/common/system/tray/special_popup_row.cc [modify] https://crrev.com/f0cd6680fbb8a4562fdb047618233b2482f6225c/ash/common/system/tray/special_popup_row.h [modify] https://crrev.com/f0cd6680fbb8a4562fdb047618233b2482f6225c/ash/common/system/tray/tray_details_view.cc [modify] https://crrev.com/f0cd6680fbb8a4562fdb047618233b2482f6225c/ash/common/system/tray/tray_details_view.h [modify] https://crrev.com/f0cd6680fbb8a4562fdb047618233b2482f6225c/ash/common/system/tray_accessibility.cc
,
Nov 16 2016
,
Nov 18 2016
verified on 56.0.2923.0 |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by tdander...@chromium.org
, Oct 4 2016