New issue
Advanced search Search tips

Issue 652670 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

102.1% regression in scheduler.tough_scheduling_cases at 422483:422539

Project Member Reported by tdres...@chromium.org, Oct 4 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=652670

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg1e7_sAoM


Bot(s) for this bug's original alert(s):

chromium-rel-win10
Cc: dtapu...@chromium.org
Owner: dtapu...@chromium.org

=== Auto-CCing suspected CL author dtapuska@chromium.org ===

Hi dtapuska@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Revert of Move synthetic gesture input to be aligned with BeginFrame. (patchset #2 id:20001 of https://codereview.chromium.org/2372873003/ )
Author  : dtapuska
Commit description:
  
Reason for revert:
Appears RenderWidgetHostViewChildFrame ends up calling a virtual during the constructor and this isn't getting called. This is an existing bug.

But the change in this CL reveals this bug so reverting this change for now.

Original issue's description:
> Move synthetic gesture input to be aligned with BeginFrame.
>
> The timing of synthetic events seems almost random. It is best to align
> it with something that doesn't fluctuate. Android already rAF aligns its
> synthetic input so do this for aura and mac as well.
>
> BUG= 646369 
>
> Committed: https://crrev.com/5248d2a4cc2ac706f0404b6c6edf196f5b491539
> Cr-Commit-Position: refs/heads/master@{#421528}

TBR=sadrul@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 646369 

Review-Url: https://codereview.chromium.org/2390813002
Cr-Commit-Position: refs/heads/master@{#422509}
Commit  : dfb4211ebbd9934c01cca376edf70fe44daa381f
Date    : Mon Oct 03 20:23:19 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev    N  Good?
chromium@422482  5.06161  0.044384   5  good
chromium@422497  5.03917  0.0898906  5  good
chromium@422504  5.23102  0.260598   5  good
chromium@422508  5.1704   0.305948   5  good
chromium@422509  10.4591  0.169706   5  bad    <--
chromium@422510  10.4721  0.168678   5  bad
chromium@422511  10.4713  0.129533   5  bad
chromium@422539  10.468   0.135381   5  bad

Bisect job ran on: winx64_10_perf_bisect
Bug ID: 652670

Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests scheduler.tough_scheduling_cases
Test Metric: mean_input_event_latency/mean_input_event_latency
Relative Change: 106.81%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_10_perf_bisect/builds/735
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8999731809560771104


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6384030574968832

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Status: WontFix (was: Untriaged)
This was the revert of begin frame aligned synthetic gestures. I will try to re-land it. But it is back to what it was previously before the begin frame aligned gestures landed.

Sign in to add a comment