New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 652666 link

Starred by 2 users
Status: Fixed
Owner:
hcarmona@chromium.org
Closed: Nov 2016
Cc:
mahmadi@chromium.org
█ hdodda@chromium.org
nyerramilli@chromium.org
█ tkonch...@chromium.org
█ msrchandra@chromium.org
dpa...@chromium.org
hcarmona@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression

Blocking:
issue 663587



Sign in to add a comment

Regression: [MD Settings] Runtime errors when searching in guest mode.

Reported by rk...@etouch.net, Oct 4 2016 
Chrome Version: 55.0.2880.0 Revision a20982650ce3e0f7ba76278fdac132a66e1b6a8f-refs/heads/master@{#422654}(32/64 bit)
OS: Mac(10.10.5)(10.11.5), Windows(7,8,8.1,10), Linux(14.04 LTS)

What steps will reproduce the problem?
(1) Launch chrome, switch to Guest mode and navigate to chrome://md-settings page.
(2) Type text in search field(e.g. Reset), then click on 'clear search' button.
(3) Now Click on 'Main menu' then click on About Chrome link and observe.

Actual: Page navigation is not properly in Guest mode after search action.

Expected: Page navigation should be properly in Guest mode.

This is a regression issue, broken in 'M-55', will soon update the other info:

Good Build: 55.0.2867.0
Bad Build: 55.0.2868.0
Actual_Video.mp4
570 KB View Download
Expected_Video.mp4
372 KB View Download

Comment 1 by brajkumar@chromium.org, Oct 4 2016

Labels: hasbisect-per-revision
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:55.0.2868.0(Revision: 419930).
Bad build: 55.0.2869.0 (Revision:420536).

You are probably looking for a change made after 420095 (known good), but no later than 420096 (first known bad).

CHANGELOG URL:
-----------------
https://chromium.googlesource.com/chromium/src/+log/7db5f539aa9c828a4b1db716b14028c73e462608..b7d1b5548da0690c04817ffa6e18ea827f844998

From the CL above, assigning the issue to the concern owner 

@dpapad - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Review-Url: https://codereview.chromium.org/2350313003

Thanks!

Comment 2 by tkonch...@chromium.org, Oct 4 2016

Labels: Proj-MaterialDesign-WebUI

Comment 3 by dpa...@chromium.org, Oct 13 2016

Labels: -Pri-1 Pri-2

Comment 4 by dpa...@chromium.org, Nov 7 2016

Cc: hcarmona@chromium.org

Comment 5 by dpa...@chromium.org, Nov 14 2016

Summary: Regression: [MD Settings] Runtime errors when searching in guest mode. (was: Regression: [MD Settings]Page navigation is not properly in 'Guest' mode after search action.)
guust_exceptions.png
26.7 KB View Download

Comment 6 by dpa...@chromium.org, Nov 14 2016

Cc: msrchandra@chromium.org mahmadi@chromium.org dpa...@chromium.org hdodda@chromium.org
 Issue 664116  has been merged into this issue.

Comment 7 by hcarmona@chromium.org, Nov 15 2016

Blocking: 663587

Comment 8 by hcarmona@chromium.org, Nov 16 2016 

Old settings didn't have search in guest mode on desktop.

Would it make sense to remove search in guest mode on desktop because there's only 1 searchable section?

Comment 9 by hcarmona@chromium.org, Nov 16 2016

Owner: hcarmona@chromium.org
Status: Started (was: Assigned)

Comment 10 by dbeam@chromium.org, Nov 17 2016 

yes, it'd make sense to hide search when there's no reason to (really)

Comment 11 by dbeam@chromium.org, Nov 17 2016

Blocking: 614588

Comment 12 by dbeam@chromium.org, Nov 17 2016

Blocking: -614588
whooops
Project Member

Comment 13 by bugdroid1@chromium.org, Nov 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88eb4e208df6ec8bd251d573d8e37b7a65f1dd84

commit 88eb4e208df6ec8bd251d573d8e37b7a65f1dd84
Author: hcarmona <hcarmona@chromium.org>
Date: Thu Nov 17 17:43:41 2016

MD Settings search code will not assume the Advanced section exists.

Guest Mode outside of ChromeOS does not have an Advanced section.

BUG= 652666 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2507873002
Cr-Commit-Position: refs/heads/master@{#432901}

[modify] https://crrev.com/88eb4e208df6ec8bd251d573d8e37b7a65f1dd84/chrome/browser/resources/settings/settings_main/settings_main.js

Comment 14 by hcarmona@chromium.org, Nov 17 2016

Status: Fixed (was: Started)
http://crbug.com/666036 filed to remove search.

Errors while searching are fixed.
►

Sign in to add a comment