New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 652634 link

Starred by 1 user
Status: Fixed
Owner:
█ tsergeant@chromium.org
Not on Chrome
Closed: Oct 2016
Cc:
nyerramilli@chromium.org
█ tkonch...@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Unnecessarily ’Synced tabs’ list gets collapsed after clicking on ‘Actions’ iron icon in chrome://history/syncedTabs.

Reported by yfulgaon...@etouch.net, Oct 4 2016 
Chrome Version : 55.0.2880.0 (Official Build) a20982650ce3e0f7ba76278fdac132a66e1b6a8f-refs/heads/master@{#422654} (32/64-bit)
OS: Mac(10.10.5)(10.11.5), Windows(7,8,8.1,10), Linux(14.04 LTS)

Precondition : Sign-in to chrome with an account having history ’Synced Tabs’.

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://history and click on ‘Tabs from other devices’.
2. Open devtools and click on ’Toggle device toolbar’ icon.
3. Now click on ‘Actions’ iron icon of first ’Synced tab’ entry, observe the ‘Synced tabs’ list and ‘Actions’ drop down list.

Actual : Unnecessarily ’Synced tabs’ list gets collapsed after clicking on ‘Actions’ iron icon.
Expected : Instead, only ‘Actions’ list should get opened after clicking on ‘Actions’ iron icon and ’Synced tab’ list should not collapse.

This is a regression issue broken in ‘M-55’, below is the Manual Regression and Change log URL.
Good build : 55.0.2873.0
Bad build : 55.0.2875.0

Change log URL : 
https://chromium.googlesource.com/chromium/src/+log/55.0.2873.0..55.0.2875.0?pretty=fuller&n=10000
(Unable to narrow down the range using tool as ‘sign-in to chrome’ feature is not supported in chromium builds, hence providing the suspect from change log)

Suspecting: r421430 ? from CL

@tsergeant : Please help to re-assign if your change is not the cause for this issue.
Actual_history.mov
8.2 MB Download
Expected_history_tabs.mov
5.9 MB Download
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95f84bba89a39f5d70372bb08dfb159208f6b6c0

commit 95f84bba89a39f5d70372bb08dfb159208f6b6c0
Author: tsergeant <tsergeant@chromium.org>
Date: Wed Oct 05 06:30:41 2016

MD History: Use click instead of tap events for synced device collapsing

This fixes an issue where using touch to open the synced device actions
menu would also collapse the device card, since one event used on-tap
and the other used on-click.

BUG= 652634 , 650551 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2389393002
Cr-Commit-Position: refs/heads/master@{#423091}

[modify] https://crrev.com/95f84bba89a39f5d70372bb08dfb159208f6b6c0/chrome/browser/resources/md_history/lazy_load.vulcanized.html
[modify] https://crrev.com/95f84bba89a39f5d70372bb08dfb159208f6b6c0/chrome/browser/resources/md_history/synced_device_card.html
[modify] https://crrev.com/95f84bba89a39f5d70372bb08dfb159208f6b6c0/chrome/test/data/webui/md_history/history_synced_tabs_test.js

Comment 2 by tsergeant@chromium.org, Oct 5 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment