New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 652620 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

suite_scheduler is not sending metrics | inconsistent setup calls between various autotest modules

Project Member Reported by akes...@chromium.org, Oct 4 2016

Issue description

I was trying to dig into how much load the suite scheduler is emitting and when to get insight into our overnight overload problem.

I see that the suite scheduler (site_utils/suite_scheduler/suite_scheduler.py) was set up to emit a metric ('suite/created') however a panopticon query returns no streams.

I also see that it's setup call is different from the site_utils-based setup call we are using in autoserv. Is that the reason? (incidentally that is true of the other SetupTsMonGlobalState calls in autotest).

Could you investigate in particular why we have no data from the suite scheduler, and in general if this is because we aren't consistently calling SetupTsMonGlobalState in the same way across the autotest codebase?
 
Labels: -current-issue
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/eedcb8b81de7a686746b342be4732d25ccbfb955

commit eedcb8b81de7a686746b342be4732d25ccbfb955
Author: Paul Hobbs <phobbs@google.com>
Date: Wed Oct 05 23:44:27 2016

[autotest] Fix for indirect=True metrics

Currently, chromite's @_Indirect metrics check whether they should be
indirect at import-time. Therefore, we need to create the metrics at
run-time after ts_mon has already been set up. A fix to the @_Indirect
decorator is in progress.

TEST=Tested with a local autotest instance. Unit tests still pass
BUG= chromium:652620 

Change-Id: I46f5d79921f56f5292df08a56b1de77399875861
Reviewed-on: https://chromium-review.googlesource.com/394249
Commit-Ready: Paul Hobbs <phobbs@google.com>
Tested-by: Paul Hobbs <phobbs@google.com>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/eedcb8b81de7a686746b342be4732d25ccbfb955/scheduler/agent_task.py
[modify] https://crrev.com/eedcb8b81de7a686746b342be4732d25ccbfb955/scheduler/monitor_db.py
[modify] https://crrev.com/eedcb8b81de7a686746b342be4732d25ccbfb955/scheduler/rdb_hosts.py
[modify] https://crrev.com/eedcb8b81de7a686746b342be4732d25ccbfb955/scheduler/shard/shard_client.py

Comment 3 by pho...@chromium.org, Jun 21 2017

Status: Fixed (was: Assigned)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment