New issue
Advanced search Search tips

Issue 652607 link

Starred by 2 users
Status: Archived
Owner:
paulmeyer@chromium.org
Closed: Sep 25
Cc:
lfg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug



Sign in to add a comment

:FATAL:find_request_manager.cc(440)] Check failed: Check Frame(rfh).

Project Member Reported by ukai@chromium.org, Oct 4 2016 
Version: 55.0.2880.0 (Developer Build) (64-bit) with dcheck_always_on=1
OS: Linux

What steps will reproduce the problem?
(1) not sure, while searching in page?
(2)
(3)

What is the expected output?

What do you see instead?
[21973:21973:1004/173034:FATAL:find_request_manager.cc(440)] Check failed: CheckFrame(rfh).

Program received signal SIGABRT, Aborted.
0x00007fffee85ec37 in __GI_raise (sig=sig@entry=6)
    at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
56      ../nptl/sysdeps/unix/sysv/linux/raise.c: No such file or directory.
(gdb)
(gdb)
(gdb) bt
#0  0x00007fffee85ec37 in __GI_raise (sig=sig@entry=6)
    at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
#1  0x00007fffee862028 in __GI_abort () at abort.c:89
#2  0x00007ffff7a6bd12 in base::debug::BreakDebugger() ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libbase.so
#3  0x00007ffff7a94aea in logging::LogMessage::~LogMessage() ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libbase.so
#4  0x00007ffff5703f9c in content::FindRequestManager::SendFindIPC(content::FindRequestManager::FindRequest const&, content::RenderFrameHost*) ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libcontent.so
#5  0x00007ffff5702c42 in content::FindRequestManager::FindInternal(content::FindRequestManager::FindRequest const&) ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libcontent.so
#6  0x00007ffff5703462 in content::FindRequestManager::AdvanceQueue(int) ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libcontent.so
#7  0x00007ffff5703715 in content::FindRequestManager::FinalUpdateReceived(int, content::RenderFrameHost*) ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libcontent.so
#8  0x00007ffff5703ae8 in content::FindRequestManager::RemoveFrame(content::RenderFrameHost*) ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libcontent.so
#9  0x00007ffff5703b2b in content::FindRequestManager::DidFinishLoad(content::RenderFrameHost*, GURL const&) ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libcontent.so
#10 0x00007ffff59ec7ea in content::WebContentsImpl::OnDidFinishLoad(GURL const&) ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libcontent.so
#11 0x00007ffff59ec55e in bool IPC::MessageT<FrameHostMsg_DidFinishLoad_Meta, std::tuple<GURL>, void>::Dispatch<content::WebContentsImpl, content::WebContentsImpl, void, void (content::WebContentsImpl::*)(GURL const&)>(IPC::Message const*, content::WebContentsImpl*, content::WebContentsImpl*, void*, void (content::WebContentsImpl::*)(GURL const&)) ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libcontent.so
#12 0x00007ffff59eb157 in content::WebContentsImpl::OnMessageReceived(content::RenderViewHost*, content::RenderFrameHost*, IPC::Message const&) ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libcontent.so
#13 0x00007ffff572604f in content::RenderFrameHostImpl::OnMessageReceived(IPC::Message const&) ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libcontent.so
#14 0x00007ffff58e5f16 in content::RenderProcessHostImpl::OnMessageReceived(IPC::Message const&) ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libcontent.so
#15 0x00007ffff498ff25 in IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message const&) ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libipc.so
#16 0x00007ffff7a731a4 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask const&) ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libbase.so
#17 0x00007ffff7a9fc1b in base::MessageLoop::RunTask(base::PendingTask const&)    ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libbase.so
#18 0x00007ffff7a9ff98 in base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libbase.so
#19 0x00007ffff7aa03bb in base::MessageLoop::DoWork() ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libbase.so
#20 0x00007ffff7aa227a in base::(anonymous namespace)::WorkSourceDispatch(_GSource*, int (*)(void*), void*) ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libbase.so
#21 0x00007ffff1459e04 in g_main_dispatch (context=0x3c2ebe21dc00)
    at /build/buildd/glib2.0-2.40.2/./glib/gmain.c:3064
#22 g_main_context_dispatch (context=context@entry=0x3c2ebe21dc00)
    at /build/buildd/glib2.0-2.40.2/./glib/gmain.c:3663
#23 0x00007ffff145a048 in g_main_context_iterate (
    context=context@entry=0x3c2ebe21dc00, block=block@entry=0,
    dispatch=dispatch@entry=1, self=<optimized out>)
    at /build/buildd/glib2.0-2.40.2/./glib/gmain.c:3734
#24 0x00007ffff145a0ec in g_main_context_iteration (context=0x3c2ebe21dc00,
    may_block=0) at /build/buildd/glib2.0-2.40.2/./glib/gmain.c:3795
#25 0x00007ffff7aa1fd6 in base::MessagePumpGlib::Run(base::MessagePump::Delegate*) ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libbase.so
#26 0x00007ffff7a9f909 in base::MessageLoop::RunHandler() ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libbase.so
#27 0x00007ffff7accf10 in base::RunLoop::Run() ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libbase.so
#28 0x000055555604d6ea in ChromeBrowserMainParts::MainMessageLoopRun(int*) ()
#29 0x00007ffff56284d9 in content::BrowserMainLoop::RunMainMessageLoopParts()    ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libcontent.so
#30 0x00007ffff562b86f in content::BrowserMainRunnerImpl::Run() ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libcontent.so
#31 0x00007ffff5623fbe in content::BrowserMain(content::MainFunctionParams const&) ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libcontent.so
#32 0x00007ffff5f52f7e in content::RunNamedProcessTypeMain(std::string const&, content::MainFunctionParams const&, content::ContentMainDelegate*) ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libcontent.so
#33 0x00007ffff5f539db in content::ContentMainRunnerImpl::Run() ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libcontent.so
#34 0x00007ffff5f52270 in content::ContentMain(content::ContentMainParams const&) ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libcontent.so
#35 0x0000555555a38f0d in ChromeMain ()
#36 0x00007fffee849f45 in __libc_start_main (main=0x555555a38ec0 <main>,
    argc=2, argv=0x7fffffffdb38, init=<optimized out>, fini=<optimized out>,
    rtld_fini=<optimized out>, stack_end=0x7fffffffdb28) at libc-start.c:287
#37 0x0000555555a38ddd in _start ()

https://chromium.googlesource.com/chromium/src/+/bbaacbe524515e8eafcd04f6dc6d872d403ffed6

Please use labels and text to provide additional information.

Comment 1 by thestig@chromium.org, Oct 19 2017

Cc: lfg@chromium.org
Components: UI>Browser>FindInPage
Labels: OS-Linux
Somewhat related, I hit the check on the next line:

FATAL:find_request_manager.cc(587)] Check failed: rfh->IsRenderFrameLive()

This is while trying to repro  bug 764635  with the PDF 1.7 Spec PDF file. While the find in page was slowly progressing, I hit "find next" a couple times, got tired of waiting, and quit the browser.

Comment 2 by lfg@chromium.org, Oct 19 2017

Labels: OS-Windows
Status: Available (was: Untriaged)
Looking at the code, this happens when FindRequestManager tries to send a find request to a dead renderer. This is actually pretty easy to repro:

1. Open google.com
2. Search for 'g', then click enter to find the next match.
3. Open task manager and kill the tab.
4. Click back on the search bar and hit enter.

Comment 3 by thestig@chromium.org, Oct 19 2017 

Should the DCHECKs be turned into actual handlers then?

Comment 4 by lfg@chromium.org, Oct 19 2017

Cc: -paulmeyer@chromium.org
Labels: -Pri-3 Pri-2
Owner: paulmeyer@chromium.org
Status: Assigned (was: Available)
The second DCHECk should definitely be handled. FindRequestManager seems to assume that the main RFH is always live, which is wrong.

The first DCHECK I'm not sure how it can occur, it's probably a different type of race.

paulmeyer@, assigning to you as OWNER of find_request_manager.cc.

Comment 5 by thestig@chromium.org, Oct 19 2017 

Right, I'm hitting the second DCHECK, but the original bug reporter hit the first DCHECK a year ago. So I'm not sure if that can still occur. Should we split the two DCHECK failures into separate bugs, so I don't completely take over ukai's bug report?

Comment 6 by robliao@chromium.org, Sep 25

Status: Archived (was: Assigned)
Archiving old bugs that have only received trivial updates for some time.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
►

Sign in to add a comment