New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 652587 link

Starred by 1 user
Status: Fixed
Owner:
toyoshim@chromium.org
Closed: Oct 2016
Cc:
█ kenjibaheux@chromium.org
shaochuan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Make WebFont.CacheHit metric more accurate

Project Member Reported by toyoshim@chromium.org, Oct 4 2016 
Some changes were submitted to make WebFont.CacheHit metric more accurate.
Results seem fine on Canary and Dev.

We want to merge a series of changes to beta branch so that we can get results on stable as soon as possible.

Comment 1 by toyoshim@chromium.org, Oct 4 2016

Components: Blink>WebFonts
We have five changes that we want to merge to beta branch.
Each CL is very small.

https://codereview.chromium.org/2289113002/ Cr-Commit-Position: refs/heads/master@{#415783}
https://codereview.chromium.org/2347113002/ Cr-Commit-Position: refs/heads/master@{#419121}
https://codereview.chromium.org/2342273003/ Cr-Commit-Position: refs/heads/master@{#419144}
https://codereview.chromium.org/2359493004/ Cr-Commit-Position: refs/heads/master@{#422006}
https://codereview.chromium.org/2375353003/ Cr-Commit-Position: refs/heads/master@{#422018}

Comment 2 by toyoshim@chromium.org, Oct 4 2016

Labels: Merge-Request-54
We didn't file a bug for these fixes, but can we request a merge to the beta branch?

Comment 3 by toyoshim@chromium.org, Oct 4 2016

Cc: kenjibaheux@chromium.org shaochuan@chromium.org
cc related people

Comment 4 by dimu@chromium.org, Oct 5 2016

Labels: -Merge-Request-54 Merge-Review-54 Hotlist-Merge-Review
[Automated comment] Less than 2 weeks to go before stable on M54, manual review required.

Comment 5 by bustamante@google.com, Oct 6 2016 

Do we need this for M54?  We're less than a week from stable cut, and I'm generally only taking security/crash fixes at this point (with some exceptions).  If there's a strong reason it needs to be on 54 we can merge them, but I'd prefer to wait to M55.

Comment 6 by kenjibaheux@chromium.org, Oct 6 2016

Labels: -M-54 -Hotlist-Merge-review -Merge-Review-54 M-55
Status: Fixed (was: Started)
This would have been nice to have but understand the risk.
Reverting merge request.

Comment 7 by shaochuan@chromium.org, Oct 17 2016

Blockedon: 655076

Comment 8 Deleted

Comment 9 by shaochuan@chromium.org, Oct 19 2016

Blockedon: -655076
►

Sign in to add a comment