Issue 652583 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	█ chuntsen@chromium.org Last visit > 30 days ago
Closed:	Oct 2016
Cc:	hungte@chromium.org
Components:	Factory
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	3
Type:	Bug
merge-merged-factory-gru-8652.B VerifyIn-57 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

Shell in factory install shim crash

Project Member Reported by chuntsen@chromium.org, Oct 4 2016

Issue description

Version: Always
OS: Any chromeOS shim

What steps will reproduce the problem?
(1)Enter the S(shell) action
(2)Type false or other command return false
(3)exit then shim crash

What is the expected output?
return shim menu

What do you see instead?
error, and shim die

Comment 1 by chuntsen@chromium.org, Oct 7 2016

Status: Started (was: Assigned)
Summary: Shell in factory install shim crash (was: Shell in shim crash)

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory_installer/+/6d9afe92d7c65a0f0d47ddfab60a4b09155b5cfc

commit 6d9afe92d7c65a0f0d47ddfab60a4b09155b5cfc
Author: chuntsen <chuntsen@google.com>
Date: Fri Oct 07 06:41:42 2016

factory_install.sh: fix shell in install shim

Fix bug: When bash return false, then install shim crash.

BUG= chromium:652583 
TEST=none

Change-Id: Iaa135e286bd9cb7b59cb8926b471d873bf0450d6
Reviewed-on: https://chromium-review.googlesource.com/394396
Commit-Ready: Chun-Tsen Kuo <chuntsen@chromium.org>
Tested-by: Chun-Tsen Kuo <chuntsen@chromium.org>
Reviewed-by: Youcheng Syu <youcheng@google.com>

[modify] https://crrev.com/6d9afe92d7c65a0f0d47ddfab60a4b09155b5cfc/factory_install.sh

Comment 3 by chuntsen@chromium.org, Oct 11 2016

Status: Fixed (was: Started)

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 7 2016

Labels: merge-merged-factory-gru-8652.B

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory_installer/+/364585c8d4ae21ff801f6180677bd26a19edf87f

commit 364585c8d4ae21ff801f6180677bd26a19edf87f
Author: chuntsen <chuntsen@google.com>
Date: Fri Oct 07 06:41:42 2016

factory_install.sh: fix shell in install shim

Fix bug: When bash return false, then install shim crash.

BUG= chromium:652583 
TEST=none

Reviewed-on: https://chromium-review.googlesource.com/394396
Commit-Ready: Chun-Tsen Kuo <chuntsen@chromium.org>
Tested-by: Chun-Tsen Kuo <chuntsen@chromium.org>
Reviewed-by: Youcheng Syu <youcheng@google.com>

(cherry picked from commit 6d9afe92d7c65a0f0d47ddfab60a4b09155b5cfc)

Change-Id: I2f24e0b2f58dc93f68f988e82e81b90ed58b294e
Reviewed-on: https://chromium-review.googlesource.com/407749
Reviewed-by: Chun-Tsen Kuo <chuntsen@chromium.org>
Commit-Queue: Chun-Tsen Kuo <chuntsen@chromium.org>
Tested-by: Chun-Tsen Kuo <chuntsen@chromium.org>

[modify] https://crrev.com/364585c8d4ae21ff801f6180677bd26a19edf87f/factory_install.sh