New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 652577 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
not available
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

android_webview_test_apk (ClientOnPageFinishedTest#testCalledAfterError) on Android failing on chromium.linux/Android Tests

Project Member Reported by horo@chromium.org, Oct 4 2016

Issue description

android_webview_test_apk on Android failing on chromium.linux/Android Tests

Type: build-failure

Builders failed on: 
- Android Tests: 
  https://build.chromium.org/p/chromium.linux/builders/Android%20Tests


https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests/builds/32832/steps/android_webview_test_apk%20on%20Android/logs/stdio

I  140.377s run_tests_on_device(03d27f97006adbb7)  detected failure in org.chromium.android_webview.test.ClientOnPageFinishedTest#testCalledAfterError. raw output:
I  140.377s TimeoutThread-1-for-run_tests_on_device(05fc05a60ae4ffc7)  [host]> /b/swarm_slave/w/irLAm9Dl/third_party/android_tools/sdk/platform-tools/adb -s 05fc05a60ae4ffc7 shell '( cat /data/local/tmp/android-webview-command-line );echo %$?'
I  140.377s run_tests_on_device(03d27f97006adbb7)    INSTRUMENTATION_STATUS: numtests=1
I  140.377s run_tests_on_device(03d27f97006adbb7)    INSTRUMENTATION_STATUS: stream=
I  140.377s run_tests_on_device(03d27f97006adbb7)    org.chromium.android_webview.test.ClientOnPageFinishedTest:
I  140.377s run_tests_on_device(03d27f97006adbb7)    INSTRUMENTATION_STATUS: id=InstrumentationTestRunner
I  140.377s run_tests_on_device(03d27f97006adbb7)    INSTRUMENTATION_STATUS: test=testCalledAfterError
I  140.377s run_tests_on_device(03d27f97006adbb7)    INSTRUMENTATION_STATUS: class=org.chromium.android_webview.test.ClientOnPageFinishedTest
I  140.377s run_tests_on_device(03d27f97006adbb7)    INSTRUMENTATION_STATUS: current=1
I  140.379s run_tests_on_device(03d27f97006adbb7)    INSTRUMENTATION_STATUS_CODE: 1
I  140.379s run_tests_on_device(03d27f97006adbb7)    INSTRUMENTATION_RESULT: shortMsg=junit.framework.AssertionFailedError
I  140.379s run_tests_on_device(03d27f97006adbb7)    INSTRUMENTATION_RESULT: longMsg=junit.framework.AssertionFailedError: onPageFinished called twice for http://localhost:7/non_existent expected:<false> but was:<true>
I  140.380s run_tests_on_device(03d27f97006adbb7)    INSTRUMENTATION_CODE: 0

 

Comment 1 by horo@chromium.org, Oct 4 2016

Labels: Sheriff-Chromium

Comment 2 by horo@chromium.org, Oct 4 2016

Owner: hush@chromium.org
Status: Assigned (was: Available)
Summary: android_webview_test_apk (ClientOnPageFinishedTest#testCalledAfterError) on Android failing on chromium.linux/Android Tests (was: android_webview_test_apk (ClientOnPageFinishedTest#testCall) on Android failing on chromium.linux/Android Tests)
hush@
Could you please take a look?

Comment 3 by hush@chromium.org, Oct 4 2016

Components: Mobile>WebView

Comment 4 by hush@chromium.org, Oct 4 2016

Owner: ----
Status: Available (was: Assigned)
Anybody else want to take a look?

Comment 5 by boliu@chromium.org, Oct 4 2016

add @RetryOnFailure first pls
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ef3e0dfcbb13b2347a5a8a75df277d17eb027bf

commit 7ef3e0dfcbb13b2347a5a8a75df277d17eb027bf
Author: imcheng <imcheng@chromium.org>
Date: Tue Oct 04 21:27:56 2016

[android_webview test] Add @RetryOnFailure to testCalledAfterError

ClientOnPageFinishedTest#testCalledAfterError is flaky.

BUG= 652577 

Review-Url: https://codereview.chromium.org/2397533002
Cr-Commit-Position: refs/heads/master@{#422933}

[modify] https://crrev.com/7ef3e0dfcbb13b2347a5a8a75df277d17eb027bf/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java

Comment 7 by horo@chromium.org, Oct 5 2016

Labels: -Sheriff-Chromium

Comment 8 by dgn@chromium.org, Oct 27 2016

Cc: ti...@chromium.org mlamouri@chromium.org
Components: Infra>CQ
That test keeps failing on the CQ Trybots:

Error: junit.framework.AssertionFailedError: onPageFinished called twice for http://localhost:7/non_existent expected:<false> but was:<true>

Sample bot with flakes and pass after 2 tries: https://build.chromium.org/p/chromium.android/builders/Android%20N5X%20Swarm%20Builder/builds/5656/steps/android_webview_test_apk%20on%20Android/logs/stdio

Trybot from the CQ where it fails quite often: 
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel?numbuilds=100

Sample failing build: https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/56844


Maybe disable it completely?
Owner: yolandyan@chromium.org
Status: Assigned (was: Available)
Yoland, would you be able to take a look at this?
Sure!
It's still failing very frequently. I'm disabling it.
BTW, the guide about FlakyTest, DisabledTest at https://www.chromium.org/developers/testing/android-tests looks stale.
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ada091bdbd7f8a6e085e291bed2e680fdf31ff6f

commit ada091bdbd7f8a6e085e291bed2e680fdf31ff6f
Author: tyoshino <tyoshino@chromium.org>
Date: Fri Oct 28 07:41:54 2016

Disable flaky Android WebView test ClientOnPageFinishedTest.testCalledAfterError()

TBR=michaelbai@chromium.org
BUG= 652577 

Review-Url: https://codereview.chromium.org/2455943004
Cr-Commit-Position: refs/heads/master@{#428311}

[modify] https://crrev.com/ada091bdbd7f8a6e085e291bed2e680fdf31ff6f/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java

+tyoshino, ya, the guide is quite outdated. I will update the doc all together after doing a refactor on @Restriction and @DisableIf
Status: Archived (was: Assigned)
I think this issue no longer persist, in terms of updating the flaky/disabled test guide, I ll open a new bug for it
Labels: WebView-Disabled-Test

Sign in to add a comment