Issue metadata
Sign in to add a comment
|
Regression : In 'Add Person' overlay, ‘Select an account’ drop down list does not close after clicking on any profile picture.
Reported by
yfulgaon...@etouch.net,
Oct 4 2016
|
||||||||||||||||||||||||
Issue descriptionChrome Version : 55.0.2880.0 (Official Build) a20982650ce3e0f7ba76278fdac132a66e1b6a8f-refs/heads/master@{#422654} (32/64-bit) OS: Mac(10.10.5)(10.11.5), Windows(7,8,8.1,10), Linux(14.04 LTS) Precondition: Please make sure "Enable Material Design User Manager" flag is enabled. What steps will reproduce the problem? 1. Launch chrome and sign in to chrome using valid credentials. 2. Click on avatar icon, select ‘switch person’ and then click on ‘ADD PERSON’. 3. In ‘Add Person’ window, check ‘Supervise this person..’ checkbox and click on ’select an account’ drop down list. 4. Now click on any profile picture and observe the ’select an account’ drop down list. Actual : ‘Select an account’ drop down list does not close after clicking on profile picture. Expected : ‘Select an account’ drop down list should get closed after clicking on profile picture. This is a regression issue broken in ‘M-55’, below is the Manual Regression and Change log URL. Good build : 55.0.2868.0 Bad build : 55.0.2869.0 Change log URL : https://chromium.googlesource.com/chromium/src/+log/55.0.2868.0..55.0.2869.0?pretty=fuller&n=10000 (Unable to narrow down the range using tool as ‘sign-in to chrome’ feature is not supported in chromium builds, hence providing the suspect from change log) Suspecting: r420355 from CL @mahmadi : Please help to re-assign if your change is not the cause for this issue.
,
Nov 18 2016
We should convert user manager to use <select> instead of <paper-dropdown-menu> just like MD Settings did.
,
Nov 18 2016
thanks dpapad@. I'll address that at the earliest opportunity.
,
Nov 18 2016
Alan, what do you think it takes, in terms of UI change, to use <select> instead of <paper-dropdown-menu> similar to md-settings?
,
Nov 18 2016
+Mihai FYI as well Alan is OOO Moe. What does <select> look like? Is it no longer a dropdown list of accounts?
,
Nov 18 2016
You can see how a MD styled select looks like by looking at any dropdown in chrome://md-settings. I am also attaching a screenshot. @michaelpg: You mentioned that someone is moving the md-select out of settings so that it can be re-used elsewhere. Is there a bug tracking this?
,
Nov 18 2016
@ewald, note that there's no label here like in the paper-dropdown-menu.
,
Nov 18 2016
FYI, issue 661473 is another bug that would be eliminated by using <select>. Long story short, paper-dropdown-menu has a lot of focus/scroll/flicker issues. MD Settings moved away from it ( issue 651513 ), 17 bugs were fixed as a result of the migration. I suggest it should be done for User manager too.
,
Nov 21 2016
Seems perfectly reasonable to me. We may want to wait for Alan to get back in office though just to confirm from a UX perspective that this is okay, and figure out whether we need to update anything else as a result of this.
Moe, when you say there's no label, what exactly do you mean by that? Do you mean there's no way to have the placeholder text ("Select an account...")?
,
Nov 21 2016
ewald@, that's correct. <select> element doesn't have a placeholder. But it doesn't mean one of the select options can't act as a placeholder. I agree we should wait for Alan to comment on the UX.
,
Dec 1 2016
still waiting on the input from bettes@. msarda@, This maybe a good intro to the user manager WebUI code.
,
Dec 1 2016
Reassigning to Alan for increased visibility
,
Dec 5 2016
It's true that the settings page is now using native dropdown menus, but the ‘Select an account’ drop down list does get closed after clicking on profile picture. So is this still an issue?
,
Dec 5 2016
Please re-assign to me with your response
,
Dec 5 2016
I am still able to repro based on the repro steps in the original bug description in the latest Canary (the dropdown list stays open while clicking on different avatars for the new profile). And more generally, I think there's a question about whether we should convert the user manager to use the same <select> dropdown that settings is now using (instead of <paper-dropdown-menu>).
,
Dec 5 2016
Oh sorry, I didn't realize this is a regression. I repro'd successfully on Canary. Yes, go ahead and use the native <select> dropdown instead of the <paper> one for the user manager.
,
Dec 5 2016
Alright, let's go ahead and try doing that then. Assigning to Mihai so he can get familiar with the user manager/web UI. This isn't a high priority bug (reducing priority to 2). Let's just use the first account in the list of accounts as the default option/placeholder. Mihai, let us know if you have any more UX questions. Feel free to ask Moe for web UI questions as well.
,
Jan 5 2017
--Chrome Identity automated triaging-- This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 11 2017
,
Jun 10 2017
FYI, issue 720927 is tracking removal of remaining paper-dropdown-menu usages, including the one in md-user-manager, so merging the bugs. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by tkonch...@chromium.org
, Oct 4 2016