New issue
Advanced search Search tips

Issue 652559 link

Starred by 2 users
Status: Archived
Owner: ----
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

PRESUBMIT for Blink should not warn when adding files

Project Member Reported by yosin@chromium.org, Oct 4 2016 
When adding C++ files into third_party/WebKit/Source, PRESBUMIT warns:

** Presubmit Warnings **
When updating or adding third party code the appropriate
'README.chromium' file should also be updated with the correct
version and package information.
  third_party\webkit\Source\core\editing\SelectionTest.cpp

Comment 1 by benhenry@chromium.org, Jan 18 2017

Labels: Pri-2
Status: Available (was: Untriaged)
This has been listed as untriaged for over two weeks. Marking available.

Since the priority is P-1, dropping it.

If you disagree with either of these actions (bulk edit), please fix.

Comment 2 by raphael....@intel.com, Jan 20 2017 

The existing PRESUBMIT checks work fine here. _CheckThirdPartyReadmesUpdated() in third_party/PRESUBMIT.py already whitelists third_party/WebKit, so I'm guessing this is related to your directory being called "webkit" instead of "WebKit" on Windows.

FWIW though, on my Windows checkout the directory is called "WebKit".
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 21 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by aga...@chromium.org, Feb 21 2018

Status: Archived (was: Untriaged)
►

Sign in to add a comment