New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 652556 link

Starred by 3 users
Status: Fixed
Owner:
keishi@chromium.org
Closed: Nov 2016
Cc:
█ joh...@chromium.org
dominickn@chromium.org
█ raymes@chromium.org
haraken@chromium.org
█ f...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

content_browsertests (BackgroundSyncBrowserTest.RegisterFromIFrameWithMainFrameHost) on Ubuntu-12.04 failing on chromium.chromiumos/Linux ChromiumOS Tests (dbg)(1)

Project Member Reported by horo@chromium.org, Oct 4 2016 
content_browsertests on Ubuntu-12.04 failing on chromium.chromiumos/Linux ChromiumOS Tests (dbg)(1)

Type: build-failure

Builders failed on: 
- Linux ChromiumOS Tests (dbg)(1): 
  https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29

https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/18659/steps/content_browsertests%20on%20Ubuntu-12.04/logs/BackgroundSyncBrowserTest.RegisterFromIFrameWithMainFrameHost/text


BackgroundSyncBrowserTest.RegisterFromIFrameWithMainFrameHost (run #1):
[ RUN      ] BackgroundSyncBrowserTest.RegisterFromIFrameWithMainFrameHost
[32465:32465:1003/190906:5748203254:WARNING:audio_manager.cc(317)] Multiple instances of AudioManager detected
[32465:32465:1003/190906:5748203332:WARNING:audio_manager.cc(278)] Multiple instances of AudioManager detected
Xlib:  extension "RANDR" missing on display ":9".
[32465:32465:1003/190906:5748255696:ERROR:proxy_service.cc(1533)] ProxyConfigService for ChromeOS should be created in profile_io_data.cc::CreateProxyConfigService and this should be used only for examples.
ASSERTION FAILED: m_threadId == currentThread()
../../third_party/WebKit/Source/platform/Supplementable.h(132) : Supplement<T> *blink::Supplementable<blink::WorkerClients>::requireSupplement(const char *) [T = blink::WorkerClients]
1   0x7f10831dc11b
2   0x7f10831dc178 blink::Supplement<blink::WorkerClients>::from(blink::Supplementable<blink::WorkerClients>*, char const*)
3   0x7f108106a3ea blink::ServiceWorkerGlobalScopeClient::from(blink::ExecutionContext*)
4   0x7f108106f78d
5   0x7f108205a7c8 blink::V8ScriptRunner::setCacheTimeStamp(blink::CachedMetadataHandler*)
6   0x7f1082058484
7   0x7f1082057c64 blink::V8ScriptRunner::compileScript(v8::Local<v8::String>, WTF::String const&, WTF::String const&, WTF::TextPosition const&, v8::Isolate*, blink::ScriptResource*, blink::ScriptStreamer*, blink::CachedMetadataHandler*, blink::AccessControlStatus, blink::V8CacheOptions)
8   0x7f1082057e8a blink::V8ScriptRunner::compileScript(WTF::String const&, WTF::String const&, WTF::String const&, WTF::TextPosition const&, v8::Isolate*, blink::CachedMetadataHandler*, blink::AccessControlStatus, blink::V8CacheOptions)
9   0x7f1082074634 blink::WorkerOrWorkletScriptController::evaluate(WTF::String const&, WTF::String const&, WTF::TextPosition const&, blink::CachedMetadataHandler*, blink::V8CacheOptions)
10  0x7f1082074e5b blink::WorkerOrWorkletScriptController::evaluate(blink::ScriptSourceCode const&, blink::ErrorEvent**, blink::CachedMetadataHandler*, blink::V8CacheOptions)
11  0x7f10831f2c54 blink::WorkerThread::initializeOnWorkerThread(std::unique_ptr<blink::WorkerThreadStartupData, std::default_delete<blink::WorkerThreadStartupData> >)
12  0x7f10831fd172
13  0x7f10831fd046
14  0x7f10831fcfc8
15  0x7f10831fcedc
16  0x7f108975a0db
17  0x7f108978c2e1 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask const&)
18  0x7f10874aa76e blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue(blink::scheduler::internal::WorkQueue*)
19  0x7f10874a844a blink::scheduler::TaskQueueManager::DoWork(base::TimeTicks, bool)
20  0x7f10874afb24
21  0x7f10874af9d4
22  0x7f10874af934
23  0x7f10874af80c
24  0x7f108975a0db
25  0x7f108978c2e1 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask const&)
26  0x7f1089813834 base::MessageLoop::RunTask(base::PendingTask const&)
27  0x7f1089813a64 base::MessageLoop::DeferOrRunPendingTask(base::PendingTask)
28  0x7f1089813d2e base::MessageLoop::DoWork()
29  0x7f1089827eb4 base::MessagePumpDefault::Run(base::MessagePump::Delegate*)
30  0x7f1089813431 base::MessageLoop::RunHandler()
31  0x7f10898acf34 base::RunLoop::Run()
Received signal 4 ILL_ILLOPN 7f10831dc11b
#0 0x7f108978729e base::debug::StackTrace::StackTrace()
#1 0x7f1089786ddf base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7f1090ec0cb0 <unknown>
#3 0x7f10831dc11b blink::Supplementable<>::requireSupplement()
#4 0x7f10831dc178 blink::Supplement<>::from()
#5 0x7f108106a3ea blink::ServiceWorkerGlobalScopeClient::from()
#6 0x7f108106f78d blink::ServiceWorkerScriptCachedMetadataHandler::setCachedMetadata()
#7 0x7f108205a7c8 blink::V8ScriptRunner::setCacheTimeStamp()
#8 0x7f1082058484 blink::(anonymous namespace)::selectCompileFunction()
#9 0x7f1082057c64 blink::V8ScriptRunner::compileScript()
#10 0x7f1082057e8a blink::V8ScriptRunner::compileScript()
#11 0x7f1082074634 blink::WorkerOrWorkletScriptController::evaluate()
#12 0x7f1082074e5b blink::WorkerOrWorkletScriptController::evaluate()
#13 0x7f10831f2c54 blink::WorkerThread::initializeOnWorkerThread()
#14 0x7f10831fd172 _ZN4base8internal13FunctorTraitsIMN5blink12WorkerThreadEFvSt10unique_ptrINS2_23WorkerThreadStartupDataESt14default_deleteIS5_EEEvE6InvokeIPS3_JS8_EEEvSA_OT_DpOT0_
#15 0x7f10831fd046 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN5blink12WorkerThreadEFvSt10unique_ptrINS4_23WorkerThreadStartupDataESt14default_deleteIS7_EEEJPS5_SA_EEEvOT_DpOT0_
#16 0x7f10831fcfc8 _ZN4base8internal7InvokerINS0_9BindStateIMN5blink12WorkerThreadEFvSt10unique_ptrINS3_23WorkerThreadStartupDataESt14default_deleteIS6_EEEJN3WTF17UnretainedWrapperIS4_LNSC_22FunctionThreadAffinityE0EEENSC_13PassedWrapperIS9_EEEEEFvvEE7RunImplIRKSB_RKSt5tupleIJSF_SH_EEJLm0ELm1EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#17 0x7f10831fcedc _ZN4base8internal7InvokerINS0_9BindStateIMN5blink12WorkerThreadEFvSt10unique_ptrINS3_23WorkerThreadStartupDataESt14default_deleteIS6_EEEJN3WTF17UnretainedWrapperIS4_LNSC_22FunctionThreadAffinityE0EEENSC_13PassedWrapperIS9_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#18 0x7f108975a0db base::internal::RunMixin<>::Run()
#19 0x7f108978c2e1 base::debug::TaskAnnotator::RunTask()
#20 0x7f10874aa76e blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue()
#21 0x7f10874a844a blink::scheduler::TaskQueueManager::DoWork()
#22 0x7f10874afb24 _ZN4base8internal13FunctorTraitsIMN5blink9scheduler16TaskQueueManagerEFvNS_9TimeTicksEbEvE6InvokeIRKNS_7WeakPtrIS4_EEJRKS5_RKbEEEvS7_OT_DpOT0_
#23 0x7f10874af9d4 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN5blink9scheduler16TaskQueueManagerEFvNS_9TimeTicksEbERKNS_7WeakPtrIS6_EEJRKS7_RKbEEEvOT_OT0_DpOT1_
#24 0x7f10874af934 _ZN4base8internal7InvokerINS0_9BindStateIMN5blink9scheduler16TaskQueueManagerEFvNS_9TimeTicksEbEJNS_7WeakPtrIS5_EES6_bEEEFvvEE7RunImplIRKS8_RKSt5tupleIJSA_S6_bEEJLm0ELm1ELm2EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#25 0x7f10874af80c _ZN4base8internal7InvokerINS0_9BindStateIMN5blink9scheduler16TaskQueueManagerEFvNS_9TimeTicksEbEJNS_7WeakPtrIS5_EES6_bEEEFvvEE3RunEPNS0_13BindStateBaseE
#26 0x7f108975a0db base::internal::RunMixin<>::Run()
#27 0x7f108978c2e1 base::debug::TaskAnnotator::RunTask()
#28 0x7f1089813834 base::MessageLoop::RunTask()
#29 0x7f1089813a64 base::MessageLoop::DeferOrRunPendingTask()
#30 0x7f1089813d2e base::MessageLoop::DoWork()
#31 0x7f1089827eb4 base::MessagePumpDefault::Run()
#32 0x7f1089813431 base::MessageLoop::RunHandler()
#33 0x7f10898acf34 base::RunLoop::Run()
#34 0x7f108994a419 base::Thread::Run()
#35 0x7f108994ac51 base::Thread::ThreadMain()
#36 0x7f1089933a0a base::(anonymous namespace)::ThreadFunc()
#37 0x7f1090eb8e9a start_thread
#38 0x7f107d0d536d clone
  r8: 000000000000003c  r9: 0101010101010101 r10: 0000000000000001 r11: 00007f107d06cd4e
 r12: 00007ffd98da5858 r13: 00007f107037c9c0 r14: 00007f1070378bc8 r15: 000006d17ece60a8
  di: 000006d17e5bc518  si: 00000000000002af  bp: 00007f1070378790  bx: 0000000000000002
  dx: 000006d17ebacec0  ax: 000000000000001f  cx: 0000000000000031  sp: 00007f1070378770
  ip: 00007f10831dc11b efl: 0000000000010202 cgf: 0000000000000033 erf: 0000000000000000
 trp: 0000000000000006 msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]
[32465:32465:1003/190907:5749408252:ERROR:browser_test_utils.cc(179)] Cannot communicate with DOMOperationObserver.
../../content/browser/background_sync/background_sync_browsertest.cc:667: Failure
Value of: RunScript(BuildScriptString("registerFromLocalFrame", url.spec()), &script_result)
  Actual: false
Expected: true
../../content/browser/background_sync/background_sync_browsertest.cc:668: Failure
Value of: script_result
  Actual: ""
Expected: BuildExpectedResult("iframe", "registered sync")
Which is: "ok - iframe registered sync"
[  FAILED  ] BackgroundSyncBrowserTest.RegisterFromIFrameWithMainFrameHost, where TypeParam =  and GetParam() =  (1843 ms)

Comment 1 by horo@chromium.org, Oct 4 2016

Labels: Pri-1 Type-Bug-Regression

Comment 3 by nhiroki@chromium.org, Oct 4 2016 

Hmmm... c#2 is not correct. This crash has occasionally happened before that.

Comment 4 by horo@chromium.org, Oct 4 2016

Cc: haraken@chromium.org
This test failure is flaky.

I added LOG(ERROR) with the attached patch and got this log:

[1:11:1004/125606:1898632595383:ERROR:Supplementable.h(141)] Supplementable::reattachThread 0x3805b079a7f8
[1:11:1004/125606:1898632595609:ERROR:Supplementable.h(143)]  m_threadId: 1
[1:11:1004/125606:1898632595776:ERROR:Supplementable.h(144)]  currentThread(): 11
[1:11:1004/125606:1898632595930:ERROR:Supplementable.h(145)]  m_threadId = currentThread();
[1:11:1004/125606:1898632605074:ERROR:ServiceWorkerScriptCachedMetadataHandler.cpp(37)] ServiceWorkerScriptCachedMetadataHandler::setCachedMetadata
[1:11:1004/125606:1898632605258:ERROR:Supplementable.h(132)] Supplementable::requireSupplement 0x3805b079a7f8
[1:11:1004/125606:1898632605414:ERROR:Supplementable.h(133)]  m_threadId: 3182967604875373612
[1:11:1004/125606:1898632605568:ERROR:Supplementable.h(134)]  currentThread(): 11
ASSERTION FAILED: m_threadId == currentThread()


3182967604875373612 is 0x2c2c2c2c2c2c2c2c.
So I think WorkerClients is broken (may be GCed?).
add_log.patch
2.2 KB Download

Comment 5 by haraken@chromium.org, Oct 4 2016

Owner: keishi@chromium.org

Comment 6 by haraken@chromium.org, Oct 4 2016

Components: Blink>MemoryAllocator>GarbageCollection

Comment 9 by horo@chromium.org, Oct 4 2016

Labels: Sheriff-Chromium

Comment 10 by horo@chromium.org, Oct 4 2016

Cc: f...@chromium.org dominickn@chromium.org joh...@chromium.org raymes@chromium.org
 Issue 652533  has been merged into this issue.

Comment 11 by horo@chromium.org, Oct 5 2016

Labels: -Sheriff-Chromium
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb7d72c8ec38f54f84c226c07c4c980283687d17

commit fb7d72c8ec38f54f84c226c07c4c980283687d17
Author: keishi <keishi@chromium.org>
Date: Wed Oct 12 07:26:35 2016

Remove CrossThreadPersistent::release

Calling CrossThreadPersistent::release was causing WorkerClients to be destroyed prematurely.
The stack for per thread heap enabled threads are invisible from other threads running GC. Using CrossThreadPersistent::release runs the risk of premature collection so we should delete it.

BUG=652001, 653272 ,652458,653657, 652556 ,653124,651790

Review-Url: https://codereview.chromium.org/2406333002
Cr-Commit-Position: refs/heads/master@{#424688}

[modify] https://crrev.com/fb7d72c8ec38f54f84c226c07c4c980283687d17/third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScope.cpp
[modify] https://crrev.com/fb7d72c8ec38f54f84c226c07c4c980283687d17/third_party/WebKit/Source/core/workers/DedicatedWorkerThread.cpp
[modify] https://crrev.com/fb7d72c8ec38f54f84c226c07c4c980283687d17/third_party/WebKit/Source/core/workers/SharedWorkerGlobalScope.cpp
[modify] https://crrev.com/fb7d72c8ec38f54f84c226c07c4c980283687d17/third_party/WebKit/Source/core/workers/SharedWorkerThread.cpp
[modify] https://crrev.com/fb7d72c8ec38f54f84c226c07c4c980283687d17/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerGlobalScope.cpp
[modify] https://crrev.com/fb7d72c8ec38f54f84c226c07c4c980283687d17/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp
[modify] https://crrev.com/fb7d72c8ec38f54f84c226c07c4c980283687d17/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.cpp
[modify] https://crrev.com/fb7d72c8ec38f54f84c226c07c4c980283687d17/third_party/WebKit/Source/platform/heap/Persistent.h

Comment 14 by falken@chromium.org, Nov 4 2016 

keishi: Can this bug be closed?

Comment 15 by falken@chromium.org, Nov 11 2016

Status: Fixed (was: Available)
I'm closing this per comment 12.

Comment 16 by nhiroki@chromium.org, Nov 25 2016 

Issue 652183 has been merged into this issue.
►

Sign in to add a comment