New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 652554 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Long OOO (go/where-is-mgiuca)
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Site Settings (Android): fullscreen subpage looks broken (transparent toggle, nothing to do...)

Project Member Reported by dbeam@chromium.org, Oct 4 2016

Issue description

if there's not much useful stuff to do, maybe just make the fullscreen row not tappable with "Always allowed" before taking the user to a page that doesn't have many options
 
Screenshot_20161003-192500.png
35.2 KB View Download
The background here is that FullScreen is going away because Chrome now always allows FullScreen. We didn't want to remove this category altogether because there could be sites in the list below the toggle, and we need to surface that list to the user for privacy reasons. We also wanted to make minimal changes to the category code because it would all be throw-away work. Therefore we (UX and Eng) agreed to just disable the toggle and change the toggle text.

The suggestion to not make the category clickable if there's nothing in the list is fine... for FullScreen. But this category should just go away. I'll ask around for the status of removing the recorded permissions for FullScreen, which is blocking the removal.
Cc: mgiuca@chromium.org
Adding Matt, who did the work to disable the toggle for this category.

Matt, has the associated FullScreen data been deleted? And if so, can this category now be deleted? I'd be happy to review such change, if you want.

Comment 3 by dbeam@chromium.org, Oct 4 2016

right, but also note: the toggle's button is transparent and looks like a rendering bug
As I recall, this is just the standard UI toggle in disabled mode. There's no styling involved so any rendering issues would need someone who knows about the default controls because I don't think we would special-case this to be all different.

Comment 5 by rolfe@chromium.org, Oct 5 2016

Cc: emilyschechter@chromium.org
Owner: rolfe@chromium.org
Status: Assigned (was: Untriaged)

Comment 7 by rolfe@chromium.org, Oct 13 2016

Owner: emilyschechter@chromium.org
emilyschecther@ to check with the eng who worked on this (I think there's plans for the design but can't remember the specifics!)
Owner: mgiuca@chromium.org
Status: Fixed (was: Assigned)
Sorry I missed this bug earlier.

This was by design, to show people that the fullscreen permission is always enabled now (while their content settings data is being stored). Though in hindsight we could've just got rid of this global setting sooner.

Oh well. I deleted it yesterday in r429474.

Sign in to add a comment