Site Settings (Android): fullscreen subpage looks broken (transparent toggle, nothing to do...) |
|||||
Issue descriptionif there's not much useful stuff to do, maybe just make the fullscreen row not tappable with "Always allowed" before taking the user to a page that doesn't have many options
,
Oct 4 2016
Adding Matt, who did the work to disable the toggle for this category. Matt, has the associated FullScreen data been deleted? And if so, can this category now be deleted? I'd be happy to review such change, if you want.
,
Oct 4 2016
right, but also note: the toggle's button is transparent and looks like a rendering bug
,
Oct 4 2016
As I recall, this is just the standard UI toggle in disabled mode. There's no styling involved so any rendering issues would need someone who knows about the default controls because I don't think we would special-case this to be all different.
,
Oct 5 2016
,
Oct 6 2016
Historical bugs for full screen being disabled: https://bugs.chromium.org/p/chromium/issues/detail?id=489239 https://bugs.chromium.org/p/chromium/issues/detail?id=611327
,
Oct 13 2016
emilyschecther@ to check with the eng who worked on this (I think there's plans for the design but can't remember the specifics!)
,
Nov 3 2016
Sorry I missed this bug earlier. This was by design, to show people that the fullscreen permission is always enabled now (while their content settings data is being stored). Though in hindsight we could've just got rid of this global setting sooner. Oh well. I deleted it yesterday in r429474. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by finnur@chromium.org
, Oct 4 2016