New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 652538 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Merging a CL about the language detection model into M54

Project Member Reported by abakalov@chromium.org, Oct 4 2016

Issue description

We'd like to merge the following CL into M54:
https://codereview.chromium.org/2392443002/

This CL improves the language detection model CLD3. More specifically, it tunes the parameters used to decide whether a prediction as reliable or not.
 
Description: Show this description
Cc: djweiss@chromium.org zkoch@chromium.org riesa@chromium.org
Labels: Merge-Request-54
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a163883df6152024ecd17b445d4d60d382aa7644

commit a163883df6152024ecd17b445d4d60d382aa7644
Author: abakalov <abakalov@chromium.org>
Date: Tue Oct 04 03:45:39 2016

Updating the CLD3 commit hash in DEPS

The changes to CLD3 are:
- tuning the probability threshold for deciding if a prediction
  is reliable or not
- improving the text processing in the function FindLanguage
  which is currently not used in Chrome

BUG= 652538 

Review-Url: https://codereview.chromium.org/2392443002
Cr-Commit-Position: refs/heads/master@{#422695}

[modify] https://crrev.com/a163883df6152024ecd17b445d4d60d382aa7644/DEPS

Comment 4 by dimu@chromium.org, Oct 4 2016

Labels: -Merge-Request-54 Merge-Review-54 Hotlist-Merge-Review
[Automated comment] DEPS changes referenced in bugdroid comments, needs manual review.
Labels: -Merge-Review-54 Merge-Rejected-54
I'd prefer to wait until M55 on this, since we're cutting stable in a few days, and taking in a new DEPS change sounds risky.  If there's a strong reason it needs to go in this milestone, feel free to push back.
Status: Fixed (was: Untriaged)
Looks like this patch landed so marking as fixed but please change it back if not.

Sign in to add a comment