Issue metadata
Sign in to add a comment
|
virtual/threaded/http/tests/worklet/animation-worklet-import.html is leaking |
||||||||||||||||||||||
Issue descriptionwebkit_tests failing on chromium.webkit/WebKit Linux Precise Leak Type: build-failure Builders failed on: - WebKit Linux Precise Leak: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Precise%20Leak virtual/threaded/http/tests/worklet/animation-worklet-import.html is leaking: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Precise_Leak/439/layout-test-results/virtual/threaded/http/tests/worklet/animation-worklet-import-leak-log.txt ({"numberOfLiveActiveDOMObjects":[2,5],"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,19],"numberOfLiveResources":[0,3]})
,
Oct 4 2016
,
Oct 4 2016
Adding animation-worklet-import.html to LeakExpectations. https://codereview.chromium.org/2384393002
,
Oct 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/efb69e929e9d90ddf3d4ce2c98e6bb1400be015a commit efb69e929e9d90ddf3d4ce2c98e6bb1400be015a Author: horo <horo@chromium.org> Date: Tue Oct 04 05:39:55 2016 Add virtual/threaded/http/tests/worklet/animation-worklet-import.html to LeakExpectations BUG= 652535 TBR=ikilpatrick@chromium.org Review-Url: https://codereview.chromium.org/2384393002 Cr-Commit-Position: refs/heads/master@{#422715} [modify] https://crrev.com/efb69e929e9d90ddf3d4ce2c98e6bb1400be015a/third_party/WebKit/LayoutTests/LeakExpectations
,
Oct 4 2016
,
Oct 4 2016
+majid
,
Oct 5 2016
,
Oct 5 2016
,
Oct 6 2016
,
Nov 4 2016
ikilpatrick: Do you have any ideas why this happens? The test is also flakily crashing on the leak bot: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fthreaded%2Fhttp%2Ftests%2Fworklet%2Fanimation-worklet-import.html
,
Nov 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/643218b3cc1e809e8fbb5f23e1300d18a676dff4 commit 643218b3cc1e809e8fbb5f23e1300d18a676dff4 Author: ikilpatrick <ikilpatrick@chromium.org> Date: Wed Nov 09 23:40:16 2016 [worklets] Fixes leak document leak for AnimationWorklet. It looks like this may have been a reference cycle between Document and AnimationWorklet. AnimationWorklet had a ThreadedMessagingProxyBase which held a persistent to Document. (ThreadedMessagingProxyBase was a raw pointer). The AnimationWorklet destructor was never being called at the right time to destroy the ThreadedMessagingProxyBase. Test: ./third_party/WebKit/Tools/Scripts/run-webkit-tests -t Default --additional-driver-flag=--enable-leak-detection third_party/WebKit/LayoutTests/virtual/threaded/http/tests/worklet/animation-worklet-import.html BUG= 652535 Review-Url: https://codereview.chromium.org/2482393002 Cr-Commit-Position: refs/heads/master@{#431081} [modify] https://crrev.com/643218b3cc1e809e8fbb5f23e1300d18a676dff4/third_party/WebKit/LayoutTests/LeakExpectations [modify] https://crrev.com/643218b3cc1e809e8fbb5f23e1300d18a676dff4/third_party/WebKit/Source/modules/compositorworker/WindowAnimationWorklet.cpp [modify] https://crrev.com/643218b3cc1e809e8fbb5f23e1300d18a676dff4/third_party/WebKit/Source/modules/compositorworker/WindowAnimationWorklet.h
,
Nov 10 2016
Now passing the leak bot: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Precise%20Leak/builds/1622 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by horo@chromium.org
, Oct 4 2016