New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 652529 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue 645114



Sign in to add a comment

Race in remoting::AutoThread::StartWithType

Project Member Reported by thestig@chromium.org, Oct 4 2016

Issue description

From r422208:

https://build.chromium.org/p/chromium.memory.full/builders/Linux%20TSan%20Tests/builds/2151

WARNING: ThreadSanitizer: data race (pid=13320)
  Write of size 8 at 0x7b1400003578 by main thread:
    #0 remoting::AutoThread::StartWithType(base::MessageLoop::Type) remoting/base/auto_thread.cc:159:17 (remoting_unittests+0x000000772f0d)
    #1 remoting::AutoThread::CreateWithType(char const*, scoped_refptr<remoting::AutoThreadTaskRunner>, base::MessageLoop::Type) remoting/base/auto_thread.cc:73:61 (remoting_unittests+0x000000772e53)
    #2 remoting::AutoThread::Create(char const*, scoped_refptr<remoting::AutoThreadTaskRunner>) remoting/base/auto_thread.cc:82:10 (remoting_unittests+0x000000772fec)
    #3 remoting::AudioDecodeSchedulerTest::SetUp() remoting/client/audio_decode_scheduler_unittest.cc:45:31 (remoting_unittests+0x000000505e7a)

  Previous read of size 8 at 0x7b1400003578 by thread T1:
    #0 remoting::AutoThread::ThreadMain() remoting/base/auto_thread.cc:214:7 (remoting_unittests+0x000000773542)
    #1 base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:71:13 (remoting_unittests+0x000000cc2afd)

  Location is heap block of size 72 at 0x7b1400003570 allocated by main thread:
    #0 operator new(unsigned long) <null> (remoting_unittests+0x0000004e0d02)
    #1 remoting::AutoThread::CreateWithType(char const*, scoped_refptr<remoting::AutoThreadTaskRunner>, base::MessageLoop::Type) remoting/base/auto_thread.cc:72:24 (remoting_unittests+0x000000772dcc)
    #2 remoting::AutoThread::Create(char const*, scoped_refptr<remoting::AutoThreadTaskRunner>) remoting/base/auto_thread.cc:82:10 (remoting_unittests+0x000000772fec)
    #3 remoting::AudioDecodeSchedulerTest::SetUp() remoting/client/audio_decode_scheduler_unittest.cc:45:31 (remoting_unittests+0x000000505e7a)

 

Comment 1 by w...@chromium.org, Oct 4 2016

Issue is that crrev.com/2378663006 added code which touches startup_data_ after having signalled startup_data_->event - left a note on the CL.
Status: Fixed (was: Untriaged)
Fixed in crrev.com/422909
Owner: isheriff@chromium.org

Sign in to add a comment