http/tests/loading/image-picture-no-download-after-removal.html is flaky |
||||
Issue description
Repro steps:
1. Build layout tests:
$ cat out/gn/args.gn | grep -v '^#'
dcheck_always_on = true
is_asan = true
is_component_build = true
is_debug = false
use_goma = true
enable_nacl = false
$ ninja -C out/gn -j 1500 -l 15 blink_tests
2. Run http/tests/loading/image-picture-no-download-after-removal.html
multiple times:
DISPLAY=:20 third_party/WebKit/Tools/Scripts/run-webkit-tests -v -t gn --no-retry-failures --iterations=200 http/tests/loading/image-picture-no-download-after-removal.html
Expected: The test consistently passes.
Actual: The test fails intermittently - 34/400 test runs failed on my machine.
,
Oct 7 2016
,
Oct 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ea50761e75c1752ec0bf619106bfa63f9372dae commit 1ea50761e75c1752ec0bf619106bfa63f9372dae Author: yoav <yoav@yoav.ws> Date: Tue Oct 11 05:04:33 2016 Avoid <picture> preloading when viewport not initialized. On rare occasions, it seems that viewport dimensions are not properly initialized before being passed to the HTMLPreloadScanner, which results in potential preloading of the wrong <picture> based resource. That issue will no longer be relevant once ParseHTMLOnMainThread lands and MediaValuesCached related logic is removed from the preloadScanner, but in the mean time, it's causing test flakiness. This CL changes the preload scanner's behavior, so that it would avoid preloading of picture based resources when the viewport dimensions are unknown. BUG= 652513 Review-Url: https://codereview.chromium.org/2404463002 Cr-Commit-Position: refs/heads/master@{#424373} [modify] https://crrev.com/1ea50761e75c1752ec0bf619106bfa63f9372dae/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp
,
Mar 29 2017
,
Apr 10 2017
I think this was resolved by https://codereview.chromium.org/2404463002 (and I neglected to mark it as such at the time :/) Marking as FIXED, but let me know if you still see flakiness. |
||||
►
Sign in to add a comment |
||||
Comment 1 by foolip@chromium.org
, Oct 4 2016Status: Assigned (was: Untriaged)