Screenshots for https://codereview.chromium.org/2632653002/
[Harmony External Protocol request dialog on MacViews]

Deleted: external_1.png 15.9 KB

	external_1.png 15.9 KB View Download

Deleted: external_2.png 57.7 KB

	external_2.png 57.7 KB View Download

To invoke this dialog, click on any of the links here - https://jsfiddle.net/cu7no5Lo/.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8473e8aa7a2b5b140bd5e6c77f8abab98adb539

commit c8473e8aa7a2b5b140bd5e6c77f8abab98adb539
Author: karandeepb <karandeepb@chromium.org>
Date: Tue Jan 24 09:12:25 2017

MacViews: Enable views based External Protocol dialog behind secondary-ui-md flag.

This CL puts the views based External Protocol dialog behind the secondary-ui-md
flag. As a result, the views based version is shown with the flag "secondary-ui-
md" enabled and the Cocoa version is shown without it.

BUG= 662128 ,  652508 

Review-Url: https://codereview.chromium.org/2632653002
Cr-Commit-Position: refs/heads/master@{#445688}

[modify] https://crrev.com/c8473e8aa7a2b5b140bd5e6c77f8abab98adb539/chrome/browser/ui/BUILD.gn
[rename] https://crrev.com/c8473e8aa7a2b5b140bd5e6c77f8abab98adb539/chrome/browser/ui/cocoa/external_protocol_dialog_cocoa.mm
[add] https://crrev.com/c8473e8aa7a2b5b140bd5e6c77f8abab98adb539/chrome/browser/ui/cocoa/external_protocol_dialog_views_mac.mm
[modify] https://crrev.com/c8473e8aa7a2b5b140bd5e6c77f8abab98adb539/chrome/browser/ui/views/external_protocol_dialog.cc
[modify] https://crrev.com/c8473e8aa7a2b5b140bd5e6c77f8abab98adb539/chrome/test/BUILD.gn

Re: c#4 - I don't get a dialog when I click any of those links (with the secondary ui flag turned on or off).

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2a77763b8027b381dd59c164cb1af3f419b7600

commit a2a77763b8027b381dd59c164cb1af3f419b7600
Author: Bret Sepulveda <bsep@chromium.org>
Date: Thu Aug 31 21:43:30 2017

Refactor ExternalProtocolDialog to remove empty space.

There's a blank patch of space in the layout due to the dialog using
MessageBoxView without a message. This patch simplifies the layout. This
should also take care of all dialog-specific changes needed for Harmony.

Bug:  652508 
Change-Id: I71936e36b860c04f3eca6f95c693d07ebff61ed1
Reviewed-on: https://chromium-review.googlesource.com/639342
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499018}
[modify] https://crrev.com/a2a77763b8027b381dd59c164cb1af3f419b7600/chrome/browser/ui/views/external_protocol_dialog.cc
[modify] https://crrev.com/a2a77763b8027b381dd59c164cb1af3f419b7600/chrome/browser/ui/views/external_protocol_dialog.h
[modify] https://crrev.com/a2a77763b8027b381dd59c164cb1af3f419b7600/chrome/browser/ui/views/external_protocol_dialog_browsertest.cc

The NextAction date has arrived: 2017-11-10

Ready for review, see attached screenshots. Or visit https://www.mirc.com/mirclink.html to test.

Deleted: external-protocol-harmony-1.PNG 19.4 KB

	external-protocol-harmony-1.PNG 19.4 KB View Download

Deleted: external-protocol-harmony-2.PNG 19.5 KB

	external-protocol-harmony-2.PNG 19.5 KB View Download

Remove "close-x" button and we'll be good to go.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96bba64e3de01afce7aafc23765f199f9efdecf5

commit 96bba64e3de01afce7aafc23765f199f9efdecf5
Author: Bret Sepulveda <bsep@chromium.org>
Date: Fri Jan 12 21:40:42 2018

Remove External Protocol dialog's close-X.

The only thing that was missed on the first pass.

Bug:  652508 
Change-Id: Icf70a8613fc0e83eaf73d7fa8f482e94588b206e
Reviewed-on: https://chromium-review.googlesource.com/862696
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529072}
[modify] https://crrev.com/96bba64e3de01afce7aafc23765f199f9efdecf5/chrome/browser/ui/views/external_protocol_dialog.cc
[modify] https://crrev.com/96bba64e3de01afce7aafc23765f199f9efdecf5/chrome/browser/ui/views/external_protocol_dialog.h