New issue
Advanced search Search tips

Issue 652494 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

generate_build_files failing on chromium.chrome/Google Chrome Win

Project Member Reported by horo@chromium.org, Oct 3 2016

Issue description

generate_build_files failing on chromium.chrome/Google Chrome Win

Type: build-failure

Builders failed on: 
- Google Chrome Win: 
  https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win


https://uberchromegw.corp.google.com/i/chromium.chrome/builders/Google%20Chrome%20Win/builds/11350/steps/generate_build_files/logs/stdio
C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check
  -> returned 1
ERROR at //build/split_static_library.gni:27:7: Dependency not allowed.
      static_library(current_name) {
      ^-----------------------------
The item //chrome/browser/ui:ui_0
can not depend on //device/bluetooth/public/interfaces:experimental_interfaces
because it is not in //device/bluetooth/public/interfaces:experimental_interfaces's visibility list: [
  //device/bluetooth:mojo
  //chrome/browser:browser
  //chrome/browser/ui:ui
]

GN gen failed: 1
step returned non-zero exit code: 1
@@@STEP_FAILURE@@@
 
I already created a revert in https://codereview.chromium.org/2390933002/
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/378f20e5539db10e70f129ea9edf25acb22144ff

commit 378f20e5539db10e70f129ea9edf25acb22144ff
Author: horo <horo@chromium.org>
Date: Mon Oct 03 23:40:01 2016

Revert of bluetooth: Add device list retrieval for chrome://bluetooth-internals (patchset #16 id:280001 of https://codereview.chromium.org/2357383002/ )

Reason for revert:
generate_build_files failing on chromium.chrome/Google Chrome Win

BUG= 652494 

C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check
  -> returned 1
ERROR at //build/split_static_library.gni:27:7: Dependency not allowed.
      static_library(current_name) {
      ^-----------------------------
The item //chrome/browser/ui:ui_0
can not depend on //device/bluetooth/public/interfaces:experimental_interfaces
because it is not in //device/bluetooth/public/interfaces:experimental_interfaces's visibility list: [
  //device/bluetooth:mojo
  //chrome/browser:browser
  //chrome/browser/ui:ui
]

GN gen failed: 1
step returned non-zero exit code: 1
@@@STEP_FAILURE@@@

Original issue's description:
> bluetooth: Add device list retrieval for chrome://bluetooth-internals
>
> Changes WebUI setup to a MojoWebUI for chrome://bluetooth-internals page.
> Adds mojom files for Bluetooth service definition and internals page handler.
> Adds basic Bluetooth device retrieval using starter Bluetooth service
> implementation for logging on web front end.
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
> BUG= 651282 
>
> Committed: https://crrev.com/e619ab633a89f1c845f5fdd7584344a5914b30a9
> Cr-Commit-Position: refs/heads/master@{#422570}

TBR=dpapad@chromium.org,dcheng@chromium.org,ortuno@chromium.org,scheib@chromium.org,mbrunson@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 651282 

Review-Url: https://codereview.chromium.org/2389053002
Cr-Commit-Position: refs/heads/master@{#422601}

[modify] https://crrev.com/378f20e5539db10e70f129ea9edf25acb22144ff/chrome/browser/BUILD.gn
[modify] https://crrev.com/378f20e5539db10e70f129ea9edf25acb22144ff/chrome/browser/browser_resources.grd
[modify] https://crrev.com/378f20e5539db10e70f129ea9edf25acb22144ff/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/378f20e5539db10e70f129ea9edf25acb22144ff/chrome/browser/resources/bluetooth_internals/bluetooth_internals.js
[modify] https://crrev.com/378f20e5539db10e70f129ea9edf25acb22144ff/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/378f20e5539db10e70f129ea9edf25acb22144ff/chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_ui.cc
[modify] https://crrev.com/378f20e5539db10e70f129ea9edf25acb22144ff/device/bluetooth/BUILD.gn
[delete] https://crrev.com/84d65719f2ba3204b4c233a4ab0c4a2afdd8db51/device/bluetooth/adapter.cc
[delete] https://crrev.com/84d65719f2ba3204b4c233a4ab0c4a2afdd8db51/device/bluetooth/adapter.h
[modify] https://crrev.com/378f20e5539db10e70f129ea9edf25acb22144ff/device/bluetooth/public/interfaces/BUILD.gn
[delete] https://crrev.com/84d65719f2ba3204b4c233a4ab0c4a2afdd8db51/device/bluetooth/public/interfaces/adapter.mojom
[modify] https://crrev.com/378f20e5539db10e70f129ea9edf25acb22144ff/third_party/WebKit/public/BUILD.gn

Comment 4 by horo@chromium.org, Oct 4 2016

Labels: Sheriff-Chromium

Comment 5 by horo@chromium.org, Oct 4 2016

Owner: horo@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment