New issue
Advanced search Search tips

Issue 652484 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Update chrome/blink call-sites to use SkBlendMode

Project Member Reported by reed@google.com, Oct 3 2016

Issue description

Chrome/blink use SkXfermode::Mode in many places, but this enum is deprecated in favor of SkBlendMode.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Oct 4 2016

Labels: Hotlist-Google
Components: Blink>Paint
Owner: vmp...@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e

commit cc9c70f3fd05091ebb4966ee2f70efed0532fd3e
Author: reed <reed@google.com>
Date: Tue Nov 22 04:26:01 2016

stop using SkXfermode -- use SkBlendMode instead

Massive (mostly mechanical) refactoring from one enum name to another.

This allows us to undefine SK_SUPPORT_LEGACY_XFERMODE_IS_PUBLIC, so we can (next) eliminate SkXfermode.h entirely

BUG= 652484 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=

Review-Url: https://codereview.chromium.org/2502373003
Cr-Commit-Position: refs/heads/master@{#433788}

[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/ash/mus/frame/custom_frame_view_mus.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/ash/utility/screenshot_controller.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/blimp/layer_tree_host_unittest_serialization.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/blink/web_blend_mode.h
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/blink/web_display_item_list_impl.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/blink/web_display_item_list_impl.h
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/ipc/cc_param_traits_macros.h
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/ipc/cc_param_traits_unittest.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/ipc/shared_quad_state_struct_traits.h
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/ipc/struct_traits_unittest.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/layers/layer.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/layers/layer.h
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/layers/layer_impl.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/layers/layer_impl.h
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/layers/layer_impl_test_properties.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/layers/layer_impl_test_properties.h
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/layers/layer_unittest.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/layers/render_surface_impl.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/layers/render_surface_impl.h
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/layers/render_surface_unittest.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/layers/solid_color_layer_impl_unittest.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/output/ca_layer_overlay.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/output/gl_renderer.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/output/gl_renderer.h
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/output/gl_renderer_unittest.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/output/overlay_candidate.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/output/overlay_unittest.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/output/renderer_pixeltest.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/output/software_renderer.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/output/software_renderer_unittest.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/playback/compositing_display_item.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/playback/compositing_display_item.h
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/playback/display_item_list_unittest.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/proto/skia_conversions.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/proto/skia_conversions.h
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/proto/skia_conversions_unittest.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/quads/draw_quad_perftest.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/quads/draw_quad_unittest.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/quads/render_pass_unittest.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/quads/shared_quad_state.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/quads/shared_quad_state.h
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/quads/texture_draw_quad.h
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/surfaces/surface_aggregator_unittest.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/surfaces/surfaces_pixeltest.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/test/render_pass_test_utils.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/test/render_pass_test_utils.h
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/test/surface_aggregator_test_helpers.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/test/surface_hittest_test_helpers.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/trees/effect_node.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/trees/effect_node.h
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/trees/layer_tree_host_pixeltest_blending.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/trees/layer_tree_host_pixeltest_masks.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/trees/occlusion_tracker.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/trees/occlusion_tracker_unittest.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/cc/trees/property_tree_builder.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/chrome/browser/chromeos/display/overscan_calibrator.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/chrome/browser/renderer_context_menu/render_view_context_menu.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/components/exo/shell_surface_unittest.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/components/exo/surface.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/components/exo/surface.h
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/components/exo/surface_unittest.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/components/exo/wayland/server.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/content/browser/compositor/mus_browser_compositor_output_surface.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/content/renderer/android/synchronous_compositor_frame_sink.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/content/renderer/media/html_video_element_capturer_source.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/content/renderer/pepper/pepper_compositor_host.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/media/renderers/skcanvas_video_renderer.h
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/services/ui/demo/bitmap_uploader.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/services/ui/ws/frame_generator.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/skia/config/SkUserConfig.h
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/skia/ext/benchmarking_canvas.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/third_party/WebKit/Source/platform/graphics/paint/CompositingDisplayItem.cpp
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/third_party/WebKit/public/platform/WebDisplayItemList.h
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/ui/aura/demo/demo_main.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/ui/aura/test/test_window_delegate.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/ui/compositor/compositing_recorder.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/ui/gfx/canvas.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/ui/gfx/canvas.h
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/ui/views/controls/progress_bar.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/ui/views/controls/scrollbar/overlay_scroll_bar.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/ui/views/widget/root_view.cc
[modify] https://crrev.com/cc9c70f3fd05091ebb4966ee2f70efed0532fd3e/ui/wm/core/image_grid.cc

Comment 5 by vmp...@chromium.org, Feb 16 2017

Status: Fixed (was: Assigned)

Sign in to add a comment