SkColorSetRGB(64, 128, 250) is substantially close to GoogleBlue500 which is SkColorSetRGB(0x42, 0x85, 0xF4). We should use gfx::GoogleBlue500 or GetNativeTheme()->GetSystemColor(ui::NativeTheme::kColorId_ProminentButtonColor) instead. https://cs.chromium.org/search/?q=%22SkColorSetRGB(64,+128,+250)%22&sq=package:chromium&type=cs
or kColorId_FocusedBorderColor ... :) :(
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e69c1ffdb22164631d597a6b44c83ecd515d5281 commit e69c1ffdb22164631d597a6b44c83ecd515d5281 Author: estade <estade@chromium.org> Date: Wed Nov 30 17:23:54 2016 Update ash shelf/tray focus rects. Also improve Canvas::DrawSolidFocusRect and Painter::CreateSolidFocusPainter. BUG=658783, 652478 ,615892 Review-Url: https://codereview.chromium.org/2527513002 Cr-Commit-Position: refs/heads/master@{#435309} [modify] https://crrev.com/e69c1ffdb22164631d597a6b44c83ecd515d5281/ash/common/ash_constants.cc [modify] https://crrev.com/e69c1ffdb22164631d597a6b44c83ecd515d5281/ash/common/ash_constants.h [modify] https://crrev.com/e69c1ffdb22164631d597a6b44c83ecd515d5281/ash/common/shelf/app_list_button.cc [modify] https://crrev.com/e69c1ffdb22164631d597a6b44c83ecd515d5281/ash/common/shelf/shelf_button.cc [modify] https://crrev.com/e69c1ffdb22164631d597a6b44c83ecd515d5281/ash/common/system/tray/actionable_view.cc [modify] https://crrev.com/e69c1ffdb22164631d597a6b44c83ecd515d5281/ash/common/system/tray/system_menu_button.cc [modify] https://crrev.com/e69c1ffdb22164631d597a6b44c83ecd515d5281/ash/common/system/tray/tray_background_view.cc [modify] https://crrev.com/e69c1ffdb22164631d597a6b44c83ecd515d5281/ash/common/system/tray/tray_popup_utils.cc [modify] https://crrev.com/e69c1ffdb22164631d597a6b44c83ecd515d5281/ash/common/system/tray/tray_popup_utils.h [modify] https://crrev.com/e69c1ffdb22164631d597a6b44c83ecd515d5281/ash/common/system/user/button_from_view.cc [modify] https://crrev.com/e69c1ffdb22164631d597a6b44c83ecd515d5281/ui/gfx/canvas.cc [modify] https://crrev.com/e69c1ffdb22164631d597a6b44c83ecd515d5281/ui/gfx/canvas.h [modify] https://crrev.com/e69c1ffdb22164631d597a6b44c83ecd515d5281/ui/views/controls/slider.cc [modify] https://crrev.com/e69c1ffdb22164631d597a6b44c83ecd515d5281/ui/views/controls/slider.h [modify] https://crrev.com/e69c1ffdb22164631d597a6b44c83ecd515d5281/ui/views/painter.cc [modify] https://crrev.com/e69c1ffdb22164631d597a6b44c83ecd515d5281/ui/views/painter.h
Is notification bubble focus rects something that belongs here or is it tracked separately?
If you are talking about the bubbles used by the message center, separate.
Comment 1 by est...@chromium.org
, Oct 4 2016