New issue
Advanced search Search tips

Issue 652462 link

Starred by 1 user
Status: Fixed
Owner:
ellyjo...@chromium.org
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 630357



Sign in to add a comment

Harmony - remove stroke from Default buttons

Project Member Reported by shrike@chromium.org, Oct 3 2016 
Per updated specs from bettes@, Default buttons should not stroke themselves in blue.

This is a change to MdTextButton. Default buttons are buttons where is_prominent_ = true.


https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20browser%20(MD)/Secondary%20UI%20Previews%20and%20specs%20(exports)/Spec#%2FSPEC-secondary-UI-04a-buttons-light-theme.png

Comment 1 by shrike@chromium.org, Oct 5 2016

Owner: ellyjo...@chromium.org

Comment 2 by ellyjo...@chromium.org, Oct 6 2016

Status: Started (was: Assigned)
Before & after screenshots for https://codereview.chromium.org/2395843003/ from my retinabook. The difference is quite difficult to see for prominent buttons but fairly apparent for non-prominent ones.
before.png
66.6 KB View Download
after.png
65.8 KB View Download

Comment 3 by shrike@chromium.org, Oct 6 2016 

Hello ellyjones@,

The change should only apply to Default (i.e. SetProminent(true)) buttons.

Can you also change the name of the non-prominent button column from Secondary to Normal (that's what what we're calling them now)?

Comment 4 by ellyjo...@chromium.org, Oct 6 2016 

Sorry - the same CL makes this change and updates the alpha of the stroke for non-default buttons, which seems to have changed in the spec.

Comment 5 by shrike@chromium.org, Oct 6 2016 

OK, great. LGTM :-)

Comment 6 by shrike@chromium.org, Oct 12 2016 

I think this is fixed?

Comment 7 by ellyjo...@chromium.org, Oct 12 2016

Status: Fixed (was: Started)
Yes, it is, by estade@'s https://codereview.chromium.org/2400563004/
►

Sign in to add a comment