New issue
Advanced search Search tips

Issue 652445 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocked on:
issue 653222
issue 653228



Sign in to add a comment

Change Chrome Apps Device Permissions Dialog using the same chooser dialog as WebUSB and WebBluetooth

Project Member Reported by juncai@chromium.org, Oct 3 2016

Issue description

It needs to change code on both non-Mac and Mac device permissions dialog implementation.
 
Components: Platform>Apps
Blockedon: 653222
Blockedon: 653228

Comment 4 by juncai@chromium.org, Nov 22 2016

Here are some screenshots.
device_permission_dialog_non_Mac.png
12.5 KB View Download
device_permission_dialog_Mac.png
28.9 KB View Download
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43003629cf2cca816884c226f18d32bc96236bb5

commit 43003629cf2cca816884c226f18d32bc96236bb5
Author: juncai <juncai@chromium.org>
Date: Tue Nov 29 20:43:18 2016

Update device permissions dialog ui for Chrome apps and extensions

This CL is part 2 of changing Chrome Apps device permissions dialog
using the same chooser dialog as WebUSB and WebBluetooth.

I uploaded some screenshots on the issue page.

BUG= 652445 ,  653228 

Review-Url: https://codereview.chromium.org/2390823005
Cr-Commit-Position: refs/heads/master@{#435075}

[modify] https://crrev.com/43003629cf2cca816884c226f18d32bc96236bb5/chrome/app/generated_resources.grd
[modify] https://crrev.com/43003629cf2cca816884c226f18d32bc96236bb5/chrome/app/nibs/BUILD.gn
[delete] https://crrev.com/c6f2275d2d7d1db5d194f46b4d08e37ebb2769b5/chrome/app/nibs/DevicePermissionsPrompt.xib
[modify] https://crrev.com/43003629cf2cca816884c226f18d32bc96236bb5/chrome/browser/chooser_controller/chooser_controller.cc
[modify] https://crrev.com/43003629cf2cca816884c226f18d32bc96236bb5/chrome/browser/chooser_controller/chooser_controller.h
[modify] https://crrev.com/43003629cf2cca816884c226f18d32bc96236bb5/chrome/browser/extensions/BUILD.gn
[add] https://crrev.com/43003629cf2cca816884c226f18d32bc96236bb5/chrome/browser/extensions/device_permissions_dialog_controller.cc
[add] https://crrev.com/43003629cf2cca816884c226f18d32bc96236bb5/chrome/browser/extensions/device_permissions_dialog_controller.h
[modify] https://crrev.com/43003629cf2cca816884c226f18d32bc96236bb5/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/43003629cf2cca816884c226f18d32bc96236bb5/chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm
[modify] https://crrev.com/43003629cf2cca816884c226f18d32bc96236bb5/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa.mm
[delete] https://crrev.com/c6f2275d2d7d1db5d194f46b4d08e37ebb2769b5/chrome/browser/ui/cocoa/extensions/device_permissions_dialog_controller.h
[delete] https://crrev.com/c6f2275d2d7d1db5d194f46b4d08e37ebb2769b5/chrome/browser/ui/cocoa/extensions/device_permissions_dialog_controller.mm
[delete] https://crrev.com/c6f2275d2d7d1db5d194f46b4d08e37ebb2769b5/chrome/browser/ui/cocoa/extensions/device_permissions_view_controller.h
[delete] https://crrev.com/c6f2275d2d7d1db5d194f46b4d08e37ebb2769b5/chrome/browser/ui/cocoa/extensions/device_permissions_view_controller.mm
[modify] https://crrev.com/43003629cf2cca816884c226f18d32bc96236bb5/chrome/browser/ui/views/chooser_content_view.cc
[modify] https://crrev.com/43003629cf2cca816884c226f18d32bc96236bb5/chrome/browser/ui/views/chooser_content_view.h
[modify] https://crrev.com/43003629cf2cca816884c226f18d32bc96236bb5/chrome/browser/ui/views/extensions/chooser_dialog_view.cc
[delete] https://crrev.com/c6f2275d2d7d1db5d194f46b4d08e37ebb2769b5/chrome/browser/ui/views/extensions/device_permissions_dialog_view.cc
[delete] https://crrev.com/c6f2275d2d7d1db5d194f46b4d08e37ebb2769b5/chrome/browser/ui/views/extensions/device_permissions_dialog_view.h
[modify] https://crrev.com/43003629cf2cca816884c226f18d32bc96236bb5/extensions/browser/BUILD.gn
[modify] https://crrev.com/43003629cf2cca816884c226f18d32bc96236bb5/extensions/browser/api/device_permissions_prompt.cc
[modify] https://crrev.com/43003629cf2cca816884c226f18d32bc96236bb5/extensions/browser/api/device_permissions_prompt.h
[delete] https://crrev.com/c6f2275d2d7d1db5d194f46b4d08e37ebb2769b5/extensions/browser/api/device_permissions_prompt_unittest.cc
[modify] https://crrev.com/43003629cf2cca816884c226f18d32bc96236bb5/extensions/browser/api/hid/hid_apitest.cc
[modify] https://crrev.com/43003629cf2cca816884c226f18d32bc96236bb5/extensions/browser/api/usb/usb_apitest.cc
[modify] https://crrev.com/43003629cf2cca816884c226f18d32bc96236bb5/extensions/strings/extensions_strings.grd

Comment 6 by juncai@chromium.org, Nov 29 2016

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Sign in to add a comment