New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 652425 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

!next->cleared() in wasm-module.cc

Project Member Reported by ClusterFuzz, Oct 3 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5304392368783360

Fuzzer: mbarbella_js_mutation
Job Type: linux_asan_d8_v8_arm_dbg
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  !next->cleared() in wasm-module.cc
  
Regressed: V8: r39889:39890

Minimized Testcase (20.39 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97EcGXVu-iXy4JkYEt88OoEfcNMHHrFQ7OA-_cmn82KFwscogiOI8QEN61815P5k7gezYb6vglI1A28VaDEmAM_B9bIn4j0ierevqw7Yh9m-YrGzNhaWQA3L0lDj382KzLlE-PGF09OB3e8U0NwYdEE9l53Hpd3MCftk_trU39tcO_Gf0A?testcase_id=5304392368783360

Issue manually filed by: mmohammad

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Owner: mtrofin@chromium.org
Status: Assigned (was: Untriaged)
looks this is the suspected :

https://chromium.googlesource.com/v8/v8/+/b4dc310aab9b8aae362bcc226a9b0bb160ed2450%5E%21/src/wasm/wasm-module.cc

mtrofin@ could you please look into this.please feel free to re-assigned back if needed. thanks in advance !


Project Member

Comment 2 by bugdroid1@chromium.org, Oct 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/c938f0df224b49d805503bbad98c4180f014e11a

commit c938f0df224b49d805503bbad98c4180f014e11a
Author: mtrofin <mtrofin@chromium.org>
Date: Tue Oct 04 21:23:02 2016

[wasm] explicitly mark off unlinked wasm module instances

This fixes a gc stress bug. We cannot rely on an ordering of
clearing of the weak cells, so we explicitly reset the weak
link to the owning instance, when finalizing a compiled
module. In turn, this serves as a reliable signal when GCs
happen while instantiating, allowing us to correctly link the
new instance.

BUG= chromium:652425 

Review-Url: https://codereview.chromium.org/2393443003
Cr-Commit-Position: refs/heads/master@{#39964}

[modify] https://crrev.com/c938f0df224b49d805503bbad98c4180f014e11a/src/wasm/wasm-module.cc
[add] https://crrev.com/c938f0df224b49d805503bbad98c4180f014e11a/test/mjsunit/regress/wasm/regression-02256.js

Project Member

Comment 3 by ClusterFuzz, Oct 5 2016

ClusterFuzz has detected this issue as fixed in range 39963:39964.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5304392368783360

Fuzzer: mbarbella_js_mutation
Job Type: linux_asan_d8_v8_arm_dbg
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  !next->cleared() in wasm-module.cc
  
Regressed: V8: r39889:39890
Fixed: V8: r39963:39964

Minimized Testcase (20.39 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97EcGXVu-iXy4JkYEt88OoEfcNMHHrFQ7OA-_cmn82KFwscogiOI8QEN61815P5k7gezYb6vglI1A28VaDEmAM_B9bIn4j0ierevqw7Yh9m-YrGzNhaWQA3L0lDj382KzLlE-PGF09OB3e8U0NwYdEE9l53Hpd3MCftk_trU39tcO_Gf0A?testcase_id=5304392368783360

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 4 by ClusterFuzz, Oct 5 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 5 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment