New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 652408 link

Starred by 1 user
Status: Fixed
Owner:
█ chongz@chromium.org
Last visit > 30 days ago
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 585875



Sign in to add a comment

InputEvent: Add prefix 'format*', 'history*' to inputType

Project Member Reported by chongz@chromium.org, Oct 3 2016 
According to TPAC 2016 we want to categorize inputType, possible approaches are:
  1. Add prefix 'format*' and 'history*', or
  2. Use supertype and subtype

There is no clear resolution, but options 1. has been added to spec and is easier to implement, so we should go with 1. for now.

TPAC discussion:
https://www.w3.org/2016/09/22-webapps-minutes.html#item04

Spec commit:
https://github.com/w3c/input-events/commit/28b3edf74f08de898c3ce6b79be621dfe3e18cc3
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5acaecd35b192852023d1be138e841c9c2c157c5

commit 5acaecd35b192852023d1be138e841c9c2c157c5
Author: chongz <chongz@chromium.org>
Date: Fri Nov 04 21:09:49 2016

[InputEvent] Add prefixes 'history*' and 'format*' to |inputType|

Latest spec added prefixes 'history*' and 'format*' to |inputType|, this
CL:
  1. Updated implementation to match spec;
  2. Cleaned unused / unsupported types.

SPEC:
https://w3c.github.io/input-events/index.html#h-interface-inputevent-attributes

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/InputEvent/blink-dev/RrnitB0OElc/rirueVekCwAJ

BUG= 652408 

Review-Url: https://codereview.chromium.org/2469483002
Cr-Commit-Position: refs/heads/master@{#430015}

[modify] https://crrev.com/5acaecd35b192852023d1be138e841c9c2c157c5/third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-execcommand.html
[modify] https://crrev.com/5acaecd35b192852023d1be138e841c9c2c157c5/third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-keyboard.html
[modify] https://crrev.com/5acaecd35b192852023d1be138e841c9c2c157c5/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/5acaecd35b192852023d1be138e841c9c2c157c5/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp
[modify] https://crrev.com/5acaecd35b192852023d1be138e841c9c2c157c5/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
[modify] https://crrev.com/5acaecd35b192852023d1be138e841c9c2c157c5/third_party/WebKit/Source/core/editing/commands/CreateLinkCommand.cpp
[modify] https://crrev.com/5acaecd35b192852023d1be138e841c9c2c157c5/third_party/WebKit/Source/core/editing/commands/CreateLinkCommand.h
[modify] https://crrev.com/5acaecd35b192852023d1be138e841c9c2c157c5/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
[modify] https://crrev.com/5acaecd35b192852023d1be138e841c9c2c157c5/third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp
[modify] https://crrev.com/5acaecd35b192852023d1be138e841c9c2c157c5/third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.h
[modify] https://crrev.com/5acaecd35b192852023d1be138e841c9c2c157c5/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp
[modify] https://crrev.com/5acaecd35b192852023d1be138e841c9c2c157c5/third_party/WebKit/Source/core/editing/commands/RemoveFormatCommand.cpp
[modify] https://crrev.com/5acaecd35b192852023d1be138e841c9c2c157c5/third_party/WebKit/Source/core/editing/commands/UnlinkCommand.cpp
[modify] https://crrev.com/5acaecd35b192852023d1be138e841c9c2c157c5/third_party/WebKit/Source/core/editing/commands/UnlinkCommand.h
[modify] https://crrev.com/5acaecd35b192852023d1be138e841c9c2c157c5/third_party/WebKit/Source/core/events/InputEvent.cpp
[modify] https://crrev.com/5acaecd35b192852023d1be138e841c9c2c157c5/third_party/WebKit/Source/core/events/InputEvent.h

Comment 2 by chongz@chromium.org, Nov 4 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment