New issue
Advanced search Search tips

Issue 652403 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 664231

Blocking:
issue 585875



Sign in to add a comment

InputEvent: Support 'insertReplacementText' for spellcheck and substitution

Project Member Reported by chongz@chromium.org, Oct 3 2016

Issue description

According to TPAC 2016 we should fire 'insertReplacementText' for all UA related text replacement, such as spellcheck, grammar check, abbr. substitution, capitalize, etc.

Resolution:
https://github.com/w3c/input-events/issues/31#issuecomment-249996730
 
Owner: chaopeng@chromium.org
Status: Started (was: Assigned)
Blockedon: 664231
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64f23d2d80977f018ecdcad5d34b78e24f98e980

commit 64f23d2d80977f018ecdcad5d34b78e24f98e980
Author: chaopeng <chaopeng@chromium.org>
Date: Tue Nov 22 05:11:24 2016

Support 'insertReplacementText' for spellcheck

In this patch, we implement the insertReplacementText input event for
spellcheck. We will not cancel the selection when the before event canceled.

This is all still behind the InputEvent experimental RuntimeEnabledFeature.

BUG= 652403 

Review-Url: https://codereview.chromium.org/2457523003
Cr-Commit-Position: refs/heads/master@{#433794}

[add] https://crrev.com/64f23d2d80977f018ecdcad5d34b78e24f98e980/third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-spellcheck.html
[modify] https://crrev.com/64f23d2d80977f018ecdcad5d34b78e24f98e980/third_party/WebKit/Source/core/clipboard/DataObject.cpp
[modify] https://crrev.com/64f23d2d80977f018ecdcad5d34b78e24f98e980/third_party/WebKit/Source/core/clipboard/DataObject.h
[modify] https://crrev.com/64f23d2d80977f018ecdcad5d34b78e24f98e980/third_party/WebKit/Source/core/clipboard/DataTransfer.h
[modify] https://crrev.com/64f23d2d80977f018ecdcad5d34b78e24f98e980/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
[modify] https://crrev.com/64f23d2d80977f018ecdcad5d34b78e24f98e980/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/64f23d2d80977f018ecdcad5d34b78e24f98e980/third_party/WebKit/Source/core/editing/Editor.h
[modify] https://crrev.com/64f23d2d80977f018ecdcad5d34b78e24f98e980/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
[modify] https://crrev.com/64f23d2d80977f018ecdcad5d34b78e24f98e980/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
[modify] https://crrev.com/64f23d2d80977f018ecdcad5d34b78e24f98e980/third_party/WebKit/Source/core/events/InputEvent.cpp
[modify] https://crrev.com/64f23d2d80977f018ecdcad5d34b78e24f98e980/third_party/WebKit/Source/core/events/InputEvent.h
[modify] https://crrev.com/64f23d2d80977f018ecdcad5d34b78e24f98e980/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/64f23d2d80977f018ecdcad5d34b78e24f98e980/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Status: Fixed (was: Started)

Sign in to add a comment