New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 652401 link

Starred by 0 users
Status: Fixed
Owner:
█ chongz@chromium.org
Last visit > 30 days ago
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 585875



Sign in to add a comment

InputEvent: Support ‘insertTranspose’ and 'insertFromYank' for macOS

Project Member Reported by chongz@chromium.org, Oct 3 2016 
Transpose and Kill&Yank are macOS only feature (following Emacs style).

Usage (inside cE or input field):
  * Transpose: Place caret in between 2 characters and press 'Ctrl-t'.
  * Kill&Yank: Place caret after a word, press 'Alt-delete' to kill a word, then press 'Ctrl-y' to yank

According to spec we should fire InputEvent to these actions:
https://w3c.github.io/input-events/#h-interface-inputevent-attributes

Related discussion:
https://github.com/w3c/input-events/issues/20
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6c436401f1cb45525882a95950af68f6a1203ee

commit f6c436401f1cb45525882a95950af68f6a1203ee
Author: chongz <chongz@chromium.org>
Date: Mon Mar 13 05:23:35 2017

[InputEvent] Support 'insertFromYank' for macOS

Yank are macOS specific feature and we need to dispatch InputEvent for it.

Please see bug for more info about yank.

BUG= 652401 

Review-Url: https://codereview.chromium.org/2738953003
Cr-Commit-Position: refs/heads/master@{#456322}

[modify] https://crrev.com/f6c436401f1cb45525882a95950af68f6a1203ee/third_party/WebKit/LayoutTests/NeverFixTests
[add] https://crrev.com/f6c436401f1cb45525882a95950af68f6a1203ee/third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-yank.html
[modify] https://crrev.com/f6c436401f1cb45525882a95950af68f6a1203ee/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
[modify] https://crrev.com/f6c436401f1cb45525882a95950af68f6a1203ee/third_party/WebKit/Source/core/editing/EditingUtilities.h
[modify] https://crrev.com/f6c436401f1cb45525882a95950af68f6a1203ee/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/f6c436401f1cb45525882a95950af68f6a1203ee/third_party/WebKit/Source/core/editing/Editor.h
[modify] https://crrev.com/f6c436401f1cb45525882a95950af68f6a1203ee/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
[modify] https://crrev.com/f6c436401f1cb45525882a95950af68f6a1203ee/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp
[modify] https://crrev.com/f6c436401f1cb45525882a95950af68f6a1203ee/third_party/WebKit/Source/core/editing/commands/TypingCommand.h
[modify] https://crrev.com/f6c436401f1cb45525882a95950af68f6a1203ee/third_party/WebKit/Source/core/events/InputEvent.cpp
[modify] https://crrev.com/f6c436401f1cb45525882a95950af68f6a1203ee/third_party/WebKit/Source/core/events/InputEvent.h

Comment 3 by chongz@chromium.org, Mar 16 2017

Labels: M-59
Status: Fixed (was: Assigned)
►

Sign in to add a comment