New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 652398 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[USS] Merge NonBlockingDataTypeController and (Non)UIModelTypeController

Project Member Reported by maxbogue@chromium.org, Oct 3 2016

Issue description

There's not really any reason these need to be different classes; they should all just be merged into a ModelTypeController class that takes a model thread argument.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f16e665b08f0c11aa735afc6ecc76e2905ae95da

commit f16e665b08f0c11aa735afc6ecc76e2905ae95da
Author: maxbogue <maxbogue@chromium.org>
Date: Wed Oct 05 00:29:17 2016

[Sync] Merge NBDTC and subclasses into ModelTypeController.

ModelTypeController simply takes a model thread into its constructor and
treats the UI thread the same as any other.

This CL contains significant cleanup of the test file as well, which contains
all the test cases from NonUiModelTypeControllerTest and
NonBlockingDataTypeControllerTest:

- It no longer uses the real SharedModelTypeProcessor implementation.
- It no longer pretends to have a sync thread that's really just the UI thread.
- There's a private section to make it clear which pieces are internal.
- A better TestBackendDataTypeConfigurer with no MockSyncBackend.

Note that ModelTypeProcessorProxy was promoted to its own file in order
to implement TestModelTypeProcessor elegantly.

BUG= 652398 

Review-Url: https://codereview.chromium.org/2384153004
Cr-Commit-Position: refs/heads/master@{#423019}

[modify] https://crrev.com/f16e665b08f0c11aa735afc6ecc76e2905ae95da/components/browser_sync/profile_sync_components_factory_impl.cc
[modify] https://crrev.com/f16e665b08f0c11aa735afc6ecc76e2905ae95da/components/sync/BUILD.gn
[add] https://crrev.com/f16e665b08f0c11aa735afc6ecc76e2905ae95da/components/sync/core/model_type_processor_proxy.cc
[add] https://crrev.com/f16e665b08f0c11aa735afc6ecc76e2905ae95da/components/sync/core/model_type_processor_proxy.h
[modify] https://crrev.com/f16e665b08f0c11aa735afc6ecc76e2905ae95da/components/sync/core/shared_model_type_processor.cc
[rename] https://crrev.com/f16e665b08f0c11aa735afc6ecc76e2905ae95da/components/sync/driver/model_type_controller.cc
[rename] https://crrev.com/f16e665b08f0c11aa735afc6ecc76e2905ae95da/components/sync/driver/model_type_controller.h
[add] https://crrev.com/f16e665b08f0c11aa735afc6ecc76e2905ae95da/components/sync/driver/model_type_controller_unittest.cc
[delete] https://crrev.com/1ce6ac5081ca02d589b419dad66470d68377bc41/components/sync/driver/non_blocking_data_type_controller_unittest.cc
[delete] https://crrev.com/1ce6ac5081ca02d589b419dad66470d68377bc41/components/sync/driver/non_ui_model_type_controller.cc
[delete] https://crrev.com/1ce6ac5081ca02d589b419dad66470d68377bc41/components/sync/driver/non_ui_model_type_controller.h
[delete] https://crrev.com/1ce6ac5081ca02d589b419dad66470d68377bc41/components/sync/driver/non_ui_model_type_controller_unittest.cc
[delete] https://crrev.com/1ce6ac5081ca02d589b419dad66470d68377bc41/components/sync/driver/ui_model_type_controller.cc
[delete] https://crrev.com/1ce6ac5081ca02d589b419dad66470d68377bc41/components/sync/driver/ui_model_type_controller.h
[delete] https://crrev.com/1ce6ac5081ca02d589b419dad66470d68377bc41/components/sync/driver/ui_model_type_controller_unittest.cc

Status: Fixed (was: Assigned)
Labels: Sync-Code-Health
Labels: -Sync-Code-Health Hotlist-CodeHealth

Sign in to add a comment