New issue
Advanced search Search tips

Issue 652392 link

Starred by 1 user
Status: Fixed
Owner:
wangxianzhu@chromium.org
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 646176



Sign in to add a comment

LayoutBox::topLeftLocation() is wrong for LayoutTableRow and LayoutTableCell in vertical-rl writing mode

Project Member Reported by wangxianzhu@chromium.org, Oct 3 2016 
It adjusts LayoutTableRow's and LayoutTableCell's location by flipping it in the containing table instead of the containing table section.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c820804326c7a2beac237fd826f73e237a05c46

commit 9c820804326c7a2beac237fd826f73e237a05c46
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Tue Oct 04 20:40:05 2016

Fix LayoutBox::topLeftLocation for table rows and table cells

Previously we used containingBlock() as the default flipped blocks
container in LayoutBox::topLeftLocation(). This was incorrect for
table rows and table cells whose locations and topLeftLocations
should be relative to the containing section.

This fixes layout tests about table row/cells in vertical writing
mode for slimmingPaintInvalidation.

BUG= 652392 

Review-Url: https://codereview.chromium.org/2392503003
Cr-Commit-Position: refs/heads/master@{#422917}

[modify] https://crrev.com/9c820804326c7a2beac237fd826f73e237a05c46/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/9c820804326c7a2beac237fd826f73e237a05c46/third_party/WebKit/Source/core/layout/LayoutBox.h
[modify] https://crrev.com/9c820804326c7a2beac237fd826f73e237a05c46/third_party/WebKit/Source/core/layout/LayoutBoxTest.cpp
[modify] https://crrev.com/9c820804326c7a2beac237fd826f73e237a05c46/third_party/WebKit/Source/core/layout/LayoutTableCell.h

Comment 2 by wangxianzhu@chromium.org, Oct 4 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment