New issue
Advanced search Search tips

Issue 652385 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 22
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 901896



Sign in to add a comment

testTrafficSettings failure on chromeos

Project Member Reported by achuith@chromium.org, Oct 3 2016

Issue description

10/03 11:52:01.336 INFO |run_chromeos_tests:0052| [575/1064] telemetry.page.page_run_end_to_end_unittest.ActualPageRunEndToEndTests.testTrafficSettings failed unexpectedly 26.3282s:
10/03 11:52:01.337 INFO |run_chromeos_tests:0052|   Traceback (most recent call last):
10/03 11:52:01.338 INFO |run_chromeos_tests:0052|     File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/page/page_run_end_to_end_unittest.py", line 364, in testTrafficSettings
10/03 11:52:01.339 INFO |run_chromeos_tests:0052|       latencies_by_page_in_ms['fast'] + 300 - 2)
10/03 11:52:01.340 INFO |run_chromeos_tests:0052|   AssertionError: 155.132080078125 not greater than 350.26318359375

Failing consistently.

CL adding this test:
https://codereview.chromium.org/2377373002/

 
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38e5dff35d1565ed8839277bf66bdbf8590dc948

commit 38e5dff35d1565ed8839277bf66bdbf8590dc948
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Mon Oct 03 22:30:06 2016

Roll src/third_party/catapult/ 6efaefc15..bd5814787 (1 commit).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6efaefc15ef4..bd5814787caa

$ git log 6efaefc15..bd5814787 --date=short --no-merges --format='%ad %ae %s'
2016-10-03 achuith Disable testTrafficSettings on chromeos.

BUG= 652385 

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2388953002
Cr-Commit-Position: refs/heads/master@{#422568}

[modify] https://crrev.com/38e5dff35d1565ed8839277bf66bdbf8590dc948/DEPS

Cc: rohi...@chromium.org
Status: Assigned (was: Untriaged)
Blocking: 901896
The problem is that ChromeOS does not proxy "localhost", which this test depends on.

See also Issue 901896.
Or at least, I suspect that is the problem. Haven't looked at the test itself yet, but ran into this failing on other platforms when enabling implicit bypass of localhost.
Confirmed localhost proxying was the problem.
Have a tentative change to fix this:
https://chromium-review.googlesource.com/c/catapult/+/1330317
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0641ede438686edea0960ac2161604bbde38627d

commit 0641ede438686edea0960ac2161604bbde38627d
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Nov 22 00:23:39 2018

Roll src/third_party/catapult d69ae20edf94..aa21a922d4a8 (4 commits)

https://chromium.googlesource.com/catapult.git/+log/d69ae20edf94..aa21a922d4a8


git log d69ae20edf94..aa21a922d4a8 --date=short --no-merges --format='%ad %ae %s'
2018-11-21 eroman@chromium.org Use ts_proxy_server on Chrome OS (remote) the same as on other platforms.
2018-11-21 lwsong@google.com Show hover text for transparent values and fixed hide Y Axis
2018-11-21 kris.selden@gmail.com Fix crashes on performance.measure name parsing.
2018-11-21 cbruni@chromium.org [pinpoint] Show bot, benchmark and story if no job title is provided


Created with:
  gclient setdep -r src/third_party/catapult@aa21a922d4a8

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:652385 
TBR=sullivan@chromium.org

Change-Id: I69efa2ee8a2fc49535873d7eb0cb427e31e5d6cb
Reviewed-on: https://chromium-review.googlesource.com/c/1347522
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#610270}
[modify] https://crrev.com/0641ede438686edea0960ac2161604bbde38627d/DEPS

Owner: eroman@chromium.org
Status: Fixed (was: Assigned)
Cc: eroman@chromium.org perezju@chromium.org cros-perf-detectives@google.com
 Issue 906529  has been merged into this issue.

Sign in to add a comment