New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 652379 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 652380

Blocking:
issue 652384



Sign in to add a comment

Programmatically update BattOr firmware when running Telemetry tests

Project Member Reported by rnep...@chromium.org, Oct 3 2016

Issue description

We need a way to be able to update all BattOrs on the perf waterfall. A person doing this manually would take too long and be inefficient. We need to implemenet a way to automatically update BattOr firmware.

DD:
https://docs.google.com/a/google.com/document/d/1UMIMaXaBnBFrXhT1n_5YIEzThBgOtPl1GsYdcPq21Js/edit?usp=sharing
 
Components: Tests>Telemetry Infra
Owner: rnep...@chromium.org
Blockedon: 652380
Labels: BattOr OS-All
Status: Assigned (was: Untriaged)
Summary: Programmatically update BattOr firmware when running Telemetry tests (was: Programatically update BattOr firmware)
Blocking: 652384

Comment 5 by s...@google.com, Oct 3 2016

Components: -Infra Infra>Client>Android
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ba00a6f09c70adacea3e0ea06a120749b9143aa

commit 4ba00a6f09c70adacea3e0ea06a120749b9143aa
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Fri Nov 04 21:08:40 2016

Roll src/third_party/catapult/ df408c3c2..edefa6f9d (3 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/df408c3c2bfb..edefa6f9d81d

$ git log df408c3c2..edefa6f9d --date=short --no-merges --format='%ad %ae %s'
2016-11-04 rnephew [BattOr] Add ability to flash BattOr to BattOr python wrapper.
2016-11-04 lpy Use <label> in radio_picker.
2016-11-04 lpy Hide histogram span when histogram.numValues === 0

BUG= 652379 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2480833002
Cr-Commit-Position: refs/heads/master@{#430014}

[modify] https://crrev.com/4ba00a6f09c70adacea3e0ea06a120749b9143aa/DEPS

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34d4058fcf46d3c6c76c60cc836aede44fe0c961

commit 34d4058fcf46d3c6c76c60cc836aede44fe0c961
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Tue Nov 08 01:37:56 2016

Roll src/third_party/catapult/ d18e525a0..672cf9d8a (5 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/d18e525a0681..672cf9d8a1ab

$ git log d18e525a0..672cf9d8a --date=short --no-merges --format='%ad %ae %s'
2016-11-07 benjhayden Display BoxChart in histogram-span for single-bin Histograms.
2016-11-07 rnephew [BattOr] Add commands to BattOr Wrapper for StopShell and GetFirmwareGitHash.
2016-11-07 rnephew [BattOr] Upload BattOr binary for win that can get git hash.
2016-11-07 eakuefner [Dashboard] Add logging to debug bisect-not-started issues
2016-11-07 benjhayden Make Histogram dict binBoundaries optional, default to single-bin.

BUG= 652379 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2484063002
Cr-Commit-Position: refs/heads/master@{#430469}

[modify] https://crrev.com/34d4058fcf46d3c6c76c60cc836aede44fe0c961/DEPS

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/116138bad2403c5f51580005842f226beab0bf2e

commit 116138bad2403c5f51580005842f226beab0bf2e
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Thu Nov 10 18:24:01 2016

Roll src/third_party/catapult/ eb34ee6a4..4b9dee111 (1 commit).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/eb34ee6a4329..4b9dee1112f9

$ git log eb34ee6a4..4b9dee111 --date=short --no-merges --format='%ad %ae %s'
2016-11-10 rnephew [BattOr] Add ability to automatically flash BattOr firmware to battor_wrapper.

BUG= 652379 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2486253003
Cr-Commit-Position: refs/heads/master@{#431295}

[modify] https://crrev.com/116138bad2403c5f51580005842f226beab0bf2e/DEPS

Cc: aschulman@chromium.org
Randy,

I don't think we can close this bug yet. I'm still seeing some firmware update errors on the Nexus 5X bots. 

For example today there are logs on the Nexus 5X bots saying:

INFO:root:Flashing BattOr with old firmware version <cbaa843> with new version <3c3ce4d>.
CRITICAL:root:Flashing firmware on this platform is not supported.

See:

https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FAndroid_Nexus5X_Perf__2_%2F3455%2F%2B%2Frecipes%2Fsteps%2Fsystem_health.common_mobile.reference%2F0%2Fstdout

Did we not build a custom BattOr avrdude binary for Linux yet?
We have an entry for it in the deps manager, not sure what is going on. Adding some logging.
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e32bd82ed3ee566e5c1b92c2d432182341bb7f95

commit e32bd82ed3ee566e5c1b92c2d432182341bb7f95
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Tue Apr 04 18:21:09 2017

Roll src/third_party/catapult/ 7726dac77..f751c1cb3 (1 commit)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/7726dac776f3..f751c1cb3afa

$ git log 7726dac77..f751c1cb3 --date=short --no-merges --format='%ad %ae %s'
2017-04-04 rnephew [BattOr] Log platform when flashing BattOr firmware is not supported.

Created with:
  roll-dep src/third_party/catapult
BUG= 652379 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2795323002
Cr-Commit-Position: refs/heads/master@{#461773}

[modify] https://crrev.com/e32bd82ed3ee566e5c1b92c2d432182341bb7f95/DEPS

Project Member

Comment 12 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ae05eaa32132bf42b7112acc1948f43142c548f

commit 9ae05eaa32132bf42b7112acc1948f43142c548f
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Wed Apr 05 02:24:41 2017

Roll src/third_party/catapult/ f0f964bdb..b3c46359b (1 commit)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/f0f964bdb9ce..b3c46359b269

$ git log f0f964bdb..b3c46359b --date=short --no-merges --format='%ad %ae %s'
2017-04-04 rnephew [BattOr] Remove platform checking for flashing BattOr firmware.

Created with:
  roll-dep src/third_party/catapult
BUG= 652379 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2793423003
Cr-Commit-Position: refs/heads/master@{#461943}

[modify] https://crrev.com/9ae05eaa32132bf42b7112acc1948f43142c548f/DEPS

Sign in to add a comment