Edit row heights |
|||||
Issue descriptionLine-heights and row heights are too small in a 640px card. Edits go as follows: settings-box (one line): 48px // formerly 44px settings-box.two-line (two line): 60px // formerly 56px Question: Are lists, radio button sets, and checkbox sets using 44px as their height? I don't want to change these instances, but want to make sure they are consistent.
,
Oct 28 2016
,
Nov 2 2016
,
Nov 3 2016
,
Nov 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b0d714461da621694d56f8949545d7da6cb551ea commit b0d714461da621694d56f8949545d7da6cb551ea Author: scottchen <scottchen@chromium.org> Date: Fri Nov 04 17:54:04 2016 Increase .settings-box and .settigns-box.two-line height. I created new variables for just the .settings-box classes, instead of increasing the settings-row-min-height values. This is because .settings-row-min-height is also used by other classes (radio buttons, check boxes, list items etc), but bettes@ specifically requested that only the box container's height be increased, and leave the other classes alone. This leads me to believe that we need separate variables for the .settings-box container so we can tweak them separately easily in the future. BUG= 652375 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2472083003 Cr-Commit-Position: refs/heads/master@{#429948} [modify] https://crrev.com/b0d714461da621694d56f8949545d7da6cb551ea/chrome/browser/resources/settings/settings_shared_css.html [modify] https://crrev.com/b0d714461da621694d56f8949545d7da6cb551ea/chrome/browser/resources/settings/settings_vars_css.html
,
Nov 4 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bettes@chromium.org
, Oct 12 2016