Ned, do you know who is the owner of smoothness.tough_image_decode_cases?

hmhh, I am not. 

+Folks: smoothness.tough_image_decode_cases is unowned. Do you know anyone who cares about this or can we delete this?

From a high level, I care about image decode performance very much.

That said, I have no idea what this particular test is doing. I'm surprised to read that it is using a python png decoder.

I would ideally like to have some perf tests for each part of the decode phase, the decode as a whole, and the decoder system. This is presumably for the decoder system. And as such, it would be a good safety net to catch problems since we don't have the other perf tests.


If it was working well, I wouldn't want to get rid of it and lose my safety net. But if it isn't even working well then it isn't much of a safety net.

I would be okay with deleting it if it isn't behaving well. But before we do, I would like to get a rough idea of what is going wrong. Is it failing because there actually is something wrong with the decoder system or is it just a bad test?

Chris: it fails when trying to scroll the page.

First failure observed: https://build.chromium.org/p/chromium.perf/builders/Win%20Zenbook%20Perf%20%284%29/builds/2285

Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8999697516364638816

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Revert of Revert "[telemetry] Wire TsProxy through telemetry's network stack." (patchset #1 id:1 of https://codereview.chromium.org/2267613002/ )
Author  : nednguyen
Commit description:
  
Reason for revert:
Webview now support --proxy-server flag (see attached bug)

Original issue's description:
> Revert "[telemetry] Wire TsProxy through telemetry's network stack."
>
> This reverts commit 9fcccf0b65703994c9541273f00a993806a95356.
>
> Revert "[Telemetry] Explictly initialize & clean up network_controller"
>
> This reverts commit 30ce231266c6fb6147bb6df7c56a7eb75c23fccf.
>
> Seems like webview currently does not support proxy server?
> (See attached chromium bug)
>
> BUG=chromium:639632
> BUG=catapult:#2584
>
> TBR=pmeenan@chromium.org
>
> Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/947506bacfb5047857a52033256635faebf38af2

TBR=nednguyen@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:639632

Review-Url: https://codereview.chromium.org/2342503002
Commit  : b86cfef4b9da4749ff51e0fc4432869f8209dc42
Date    : Wed Sep 14 00:48:51 2016


===== TESTED REVISIONS =====
Revision                             Exit Code  Std Dev  N  Good?
chromium@418385                      0          N/A      5  good
chromium@418431                      0          N/A      5  good
chromium@418454                      0          N/A      5  good
chromium@418460                      0          N/A      5  good
chromium@418462                      0          N/A      5  good
chromium@418462,catapult@7d108c71d8  0          N/A      5  good
chromium@418462,catapult@b86cfef4b9  1          N/A      5  bad    <--
chromium@418463                      1          N/A      5  bad
chromium@418466                      1          N/A      5  bad
chromium@418477                      1          N/A      5  bad

Bisect job ran on: winx64_zen_perf_bisect
Bug ID: 652372

Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests smoothness.tough_image_decode_cases
Test Metric: frame_times/http___localhost_9000_cats-viewport-width.html
Relative Change: Zero to non-zero
Score: 99.5

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_zen_perf_bisect/builds/524
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8999697516364638816


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5897550500986880

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

I believe the bisect is wrong in this case since there is no reason that this benchmark is failing only on Win zebook perf & Mac retina if the tsproxy change is the cause.

Here is the stack trace:
  File "C:\b\c\b\Win_Zenbook_Perf__4_\src\third_party\catapult\telemetry\telemetry\internal\actions\scroll.py", line 55, in WillRunAction
    if not tab.EvaluateJavaScript('window.__ScrollAction_SupportedByBrowser()'):
  File "C:\b\c\b\Win_Zenbook_Perf__4_\src\third_party\catapult\telemetry\telemetry\internal\browser\web_contents.py", line 187, in EvaluateJavaScript
    expr, context_id=None, timeout=timeout)
  File "C:\b\c\b\Win_Zenbook_Perf__4_\src\third_party\catapult\telemetry\telemetry\internal\browser\web_contents.py", line 215, in EvaluateJavaScriptInContext
    expr, context_id=context_id, timeout=timeout)
  File "C:\b\c\b\Win_Zenbook_Perf__4_\src\third_party\catapult\common\py_trace_event\py_trace_event\trace_event_impl\decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "C:\b\c\b\Win_Zenbook_Perf__4_\src\third_party\catapult\telemetry\telemetry\internal\backends\chrome_inspector\inspector_backend.py", line 34, in inner
    return func(inspector_backend, *args, **kwargs)
  File "C:\b\c\b\Win_Zenbook_Perf__4_\src\third_party\catapult\telemetry\telemetry\internal\backends\chrome_inspector\inspector_backend.py", line 208, in EvaluateJavaScript
    return self._runtime.Evaluate(expr, context_id, timeout)
  File "C:\b\c\b\Win_Zenbook_Perf__4_\src\third_party\catapult\telemetry\telemetry\internal\backends\chrome_inspector\inspector_runtime.py", line 53, in Evaluate
    raise exceptions.EvaluateException(text)
EvaluateException: Uncaught


So what happened is "Uncaught" exception is thrown in javascript when telemetry try to check "__ScrollAction_SupportedByBrowser ". It's is very likely that this is due to some synthetic gesture bug in Chrome.

Also failing on Win 10 High-DPI Perf (4)

Will go ahead and disable this test now until it is fixed.

Disable CL is up https://codereview.chromium.org/2406473002/

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4de43d33e879887cb01b0ee3f43c0ff237bebcc1

commit 4de43d33e879887cb01b0ee3f43c0ff237bebcc1
Author: zhenw <zhenw@chromium.org>
Date: Fri Oct 07 22:47:57 2016

Disable smoothness.tough_image_decode_cases on Win perf bot

TBR=nednguyen@google.com
BUG= chromium:652372 

Review-Url: https://codereview.chromium.org/2406473002
Cr-Commit-Position: refs/heads/master@{#423992}

[modify] https://crrev.com/4de43d33e879887cb01b0ee3f43c0ff237bebcc1/tools/perf/benchmarks/smoothness.py

Fixed the empty status.