Correct Tab Order and Focus for Gallery Edit Accessibility |
|||||||
Issue descriptionFor Accessibility of the Gallery App, the tab order currently does not follow the expected user workflow for the Edit functionality. The suggested order of tabbing is as follows: - Tab starts from the top line items - If Edit is selected, then bottom line options are added - On tabbing through the bottom row of options, if Crop is selected, then tab goes up to the Crop options for selection, then Cancel/Done (which is a part of that particular edit) - Then it continues through the options to Resize, etc. where if Resize is the next selected edit it again goes up to the specific edit functionality options, then Cancel/Done
,
Oct 6 2016
,
Oct 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/463197f1254e1fa220a24f8d2229b879be85bfc4 commit 463197f1254e1fa220a24f8d2229b879be85bfc4 Author: fukino <fukino@chromium.org> Date: Thu Oct 06 18:58:02 2016 Fix some accessibility issues in image editing. - Fix tab order on editing tool bar by swapping containers. - Add background color for focused buttons on editing tool. - When a editing tool is shown, the first input element should be focused. BUG= 652352 TEST=manual CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2400613002 Cr-Commit-Position: refs/heads/master@{#423615} [modify] https://crrev.com/463197f1254e1fa220a24f8d2229b879be85bfc4/ui/file_manager/gallery/css/gallery.css [modify] https://crrev.com/463197f1254e1fa220a24f8d2229b879be85bfc4/ui/file_manager/gallery/js/image_editor/image_editor.js [modify] https://crrev.com/463197f1254e1fa220a24f8d2229b879be85bfc4/ui/file_manager/gallery/js/image_editor/image_transform.js
,
Oct 12 2016
@fukino, just tried this implementation on Dev channel. A small issue I observed: - In Edit mode, tab to Brightness and click Enter - I then tab through the Brightness options, Cancel, Done (WAI) - My next tab should then take me to the "Left" Edit option, but currently it navigates back up to the upper left-hand file re-name focus. I don't think this should be a blocker for M55.
,
Oct 14 2016
OK! I'll fix the issue in c#4 for M56.
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/463197f1254e1fa220a24f8d2229b879be85bfc4 commit 463197f1254e1fa220a24f8d2229b879be85bfc4 Author: fukino <fukino@chromium.org> Date: Thu Oct 06 18:58:02 2016 Fix some accessibility issues in image editing. - Fix tab order on editing tool bar by swapping containers. - Add background color for focused buttons on editing tool. - When a editing tool is shown, the first input element should be focused. BUG= 652352 TEST=manual CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2400613002 Cr-Commit-Position: refs/heads/master@{#423615} [modify] https://crrev.com/463197f1254e1fa220a24f8d2229b879be85bfc4/ui/file_manager/gallery/css/gallery.css [modify] https://crrev.com/463197f1254e1fa220a24f8d2229b879be85bfc4/ui/file_manager/gallery/js/image_editor/image_editor.js [modify] https://crrev.com/463197f1254e1fa220a24f8d2229b879be85bfc4/ui/file_manager/gallery/js/image_editor/image_transform.js
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Nov 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c49ae19a47f0a780ed33b2341cfe56acc77efe50 commit c49ae19a47f0a780ed33b2341cfe56acc77efe50 Author: fukino <fukino@chromium.org> Date: Thu Nov 17 09:05:59 2016 Gallery: Correct tab order of modal tool bar in edit mode. The '.edit-modal' toolbar used to be inserted at the bottom in the Gallery's DOM, but it is visually shown above the #bottom-toolbar. It made the tab order inconsistent with the visual position of toolbars. This CL fixes the tab order by inserting the modal bar at the right position. BUG= 652352 TEST=In edit mode with brightness options, I comfirmed that the first element of the bottom bar ("Overrite original") was focused after I tab through the controls of brightness options. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2509223002 Cr-Commit-Position: refs/heads/master@{#432822} [modify] https://crrev.com/c49ae19a47f0a780ed33b2341cfe56acc77efe50/ui/file_manager/gallery/js/slide_mode.js
,
Nov 17 2016
,
Jan 5 2017
Verified on ChromeOS 9150.0.0, 57.0.2970.0 |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by weifangsun@chromium.org
, Oct 3 2016