Download request for an offline web page does not start loading immediately because PrerenderManager detects it has been recently visited |
|||||
Issue descriptionOffline pages is using the PrerenderManager to perform background loading. The PrerenderManager is designed to detect foreground use of the same URL and stop trying to prerender. This is not the behavior that is desired for the new Downloads feature - where a web page is slow to load in the foreground so the used can request it be loaded in the background and then do other things on the phone in the foreground (or just put in pocket). Should we modify the Prerender stack to allow the prerender request to continue even if tab is currently working on the same URL (just for the offline page request)? Specifically, this might be checking for ORIGIN_OFFLINE in PrerenderContents::CheckURL() or in PrerenderManager::HasRecentlyBeenNavigatedTo().
,
Oct 3 2016
Sounds like there is nothing to prevent a patch :)
,
Oct 3 2016
Yes, I think simple change seems attractive. Hopefully by end of the year we can be contemplating tactical plan to get onto new stack.
,
Oct 5 2016
Yes, it would be great to allow the prerender request to continue even if tab is currently working on the same URL for the offline page request to help align this feature with user expectation. If possible, it would be great to get it in for M55 branchpoint by EOW. Pasko@ are there any concerns with this or can we move forward with this approach?
,
Oct 5 2016
Egor, should I put together a CL for this?
,
Oct 5 2016
moving forward, how urgent is this? M55 is branching tomorrow, would it need cherry-picks or M56 is OK?
,
Oct 5 2016
dougarnett: if you have cycles, I would not object
,
Oct 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cafb83e8a6a24bc3df0387959373b1988baf5416 commit cafb83e8a6a24bc3df0387959373b1988baf5416 Author: dougarnett <dougarnett@chromium.org> Date: Thu Oct 06 15:36:11 2016 Allows prerendering to continue for offline requests even if the url was recently visited. This is important for the way the new Download feature works. If a link is taking a while to load, you can choose to download it (which does background load using prerender with ORIGIN_OFFLINE). We indeed were recently trying to visit it but still want to load in the background. BUG= 652350 Review-Url: https://codereview.chromium.org/2397783003 Cr-Commit-Position: refs/heads/master@{#423543} [modify] https://crrev.com/cafb83e8a6a24bc3df0387959373b1988baf5416/chrome/browser/prerender/prerender_contents.cc [modify] https://crrev.com/cafb83e8a6a24bc3df0387959373b1988baf5416/chrome/browser/prerender/prerender_unittest.cc
,
Oct 6 2016
,
Oct 10 2016
Issue 651306 has been merged into this issue.
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cafb83e8a6a24bc3df0387959373b1988baf5416 commit cafb83e8a6a24bc3df0387959373b1988baf5416 Author: dougarnett <dougarnett@chromium.org> Date: Thu Oct 06 15:36:11 2016 Allows prerendering to continue for offline requests even if the url was recently visited. This is important for the way the new Download feature works. If a link is taking a while to load, you can choose to download it (which does background load using prerender with ORIGIN_OFFLINE). We indeed were recently trying to visit it but still want to load in the background. BUG= 652350 Review-Url: https://codereview.chromium.org/2397783003 Cr-Commit-Position: refs/heads/master@{#423543} [modify] https://crrev.com/cafb83e8a6a24bc3df0387959373b1988baf5416/chrome/browser/prerender/prerender_contents.cc [modify] https://crrev.com/cafb83e8a6a24bc3df0387959373b1988baf5416/chrome/browser/prerender/prerender_unittest.cc
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840 |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by pasko@chromium.org
, Oct 3 2016Status: Assigned (was: Untriaged)