Issue 652340 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	█ bshe@chromium.org Last visit > 30 days ago
Closed:	Oct 2016
Components:	UI>Browser>VR
EstimatedDays:	----
NextAction:	----
OS:	Android
Pri:	2
Type:	Bug
M-55 Proj-VR
Proj-XR
Proj-XR-VR

"Enter VR" entry is not present from menu for release build

Project Member Reported by bshe@chromium.org, Oct 3 2016

Issue description

The root cause is VR_EXTRA is obfuscated by proguard in release.

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/823aa13816cbf9df2062089959615f6eb71b4daa

commit 823aa13816cbf9df2062089959615f6eb71b4daa
Author: bshe <bshe@chromium.org>
Date: Tue Oct 04 21:37:59 2016

Enable VR Shell for release build too

Vr Shell was disabled in release build regardless if enable_vr_shell is set
or not. The reason was proguard obfuscated the name we use in VrShellDelegate
This adds rules to prevent obfuscation.

BUG= 652340 

Review-Url: https://codereview.chromium.org/2385113003
Cr-Commit-Position: refs/heads/master@{#422940}

[modify] https://crrev.com/823aa13816cbf9df2062089959615f6eb71b4daa/base/android/proguard/chromium_code.flags
[modify] https://crrev.com/823aa13816cbf9df2062089959615f6eb71b4daa/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java