Event listeners are treated as a blackbox in the timeline
Reported by
ri.j...@gmail.com,
Oct 3 2016
|
||||||||||||
Issue descriptionChrome Version : 53.0.2785.116 and 55.0.2879.0 canary What steps will reproduce the problem? (1) Open timeline and load page with a very slow event listener (e.g. the attached test.html) (2) Notice that there are no details about what happens during the event listener execution What is the expected result? Below "Event (event-name)" should be a row with the functions which have been called during the event listener execution. What happens instead? It just shows some garbage collection activity (or nothing at all). Please provide any additional information below. Attach a screenshot if possible. I have attached: * test.html file to reproduce the problem * timeline.png which shows that the verySlowFunction() is missing if called in a event handler. At the same time, it is visible if called directly. * profile.png which shows that the profiler does not have this limitation.
,
Oct 4 2016
,
Oct 4 2016
Able to reproduce the issue in Current Chrome stable (53.0.2785.143), mac,Linux and canary(55.0.2880.0) - displays "Event(event-name)" with blank function. Manual Bisect: Good build:50.0.2633.0 Bad build:50.0.2634.0 Bisect tool info: CL : https://chromium.googlesource.com/chromium/src/+log/663559bc7a88fbe864a404f80687cf3b8f7a77ed..21a110d3e3c2367300904f9337da966f6f531b59 Possible suspect: https://codereview.chromium.org/1624783002 Please reassign if this is not related to your change.
,
Oct 4 2016
Issue 652333 has been merged into this issue.
,
Nov 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce6a35209d7ebeb969d372c0bf23c0c403bdd83d commit ce6a35209d7ebeb969d372c0bf23c0c403bdd83d Author: alph <alph@chromium.org> Date: Mon Nov 28 21:58:08 2016 DevTools: allow JS frames under EventDispatch BUG= 652332 Review-Url: https://codereview.chromium.org/2528553002 Cr-Commit-Position: refs/heads/master@{#434732} [modify] https://crrev.com/ce6a35209d7ebeb969d372c0bf23c0c403bdd83d/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js
,
Nov 28 2016
,
Nov 29 2016
Before we approve merge to M55 branch 2883, could you please make sure this change is well baked/verified in Canary/Dev and safe to merge to M55?
,
Nov 29 2016
[Automated comment] Less than 2 weeks to go before stable on M55, manual review required.
,
Nov 29 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Nov 29 2016
Per manual bisect at #3, this issue exists since M50 (50.0.2634.0). We're VERY close to M55 stable promotion and we're only taking critical merges in. Can this wait until M56?
,
Nov 30 2016
The fix is pretty safe and there's a request from a customer to fix the issue. So we'd like to merge it into M55 as well.
,
Nov 30 2016
It's not urgent for M55. It's ok if it eventually gets into M55 update.
,
Nov 30 2016
Ok, sounds good. It will miss first stable rollout but we will take it in for future M55 stable update so by then change will be baked in dev too.
,
Nov 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1199c79ab789656089f1b50f98ee4bc13da9a783 commit 1199c79ab789656089f1b50f98ee4bc13da9a783 Author: Alexei Filippov <alph@chromium.org> Date: Wed Nov 30 21:29:47 2016 DevTools: allow JS frames under EventDispatch BUG= 652332 Review-Url: https://codereview.chromium.org/2528553002 Cr-Commit-Position: refs/heads/master@{#434732} (cherry picked from commit ce6a35209d7ebeb969d372c0bf23c0c403bdd83d) Review URL: https://codereview.chromium.org/2541043003 . Cr-Commit-Position: refs/branch-heads/2924@{#209} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/1199c79ab789656089f1b50f98ee4bc13da9a783/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js
,
Dec 2 2016
Tested the same on win10 mac and Linux using chrome version 56.0.2924.14 - Observed veryslow function in "dispatchEvent" as shown in the screenshot. Event (test) is displayed without any functions Could you please let us know the expected result to verify the fix
,
Dec 5 2016
Yes, the result is expected. There are functions shown under the Dispatch Event, e.g. (anonymous).
,
Dec 5 2016
Approving merge to M55 branch 2883 based on comments #11 and #17 and per chat with alph@ this is a supersafe change. Please merge ASAP. Thank you.
,
Dec 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34ca308256952476dbf2519fbe7d70d40a942142 commit 34ca308256952476dbf2519fbe7d70d40a942142 Author: Alexei Filippov <alph@chromium.org> Date: Mon Dec 05 21:58:38 2016 DevTools: allow JS frames under EventDispatch BUG= 652332 Review-Url: https://codereview.chromium.org/2528553002 Cr-Commit-Position: refs/heads/master@{#434732} (cherry picked from commit ce6a35209d7ebeb969d372c0bf23c0c403bdd83d) Review URL: https://codereview.chromium.org/2555563002 . Cr-Commit-Position: refs/branch-heads/2883@{#711} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/34ca308256952476dbf2519fbe7d70d40a942142/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js
,
Dec 5 2016
,
Dec 7 2016
Verified this issue on Windows-10, Mac OS 10.12 and Ubuntu 14.04 using chrome latest M55 #55.0.2283.85 by following steps mentioned in the original comment. Observed veryslow function() is displayed in the event listeners timeline as expected. Hence adding TE-Verified label. |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by ligim...@chromium.org
, Oct 3 2016Labels: Needs-Bisect M-53