we stopped generating the en_US.UTF8 locale before as it was a workaround for a bug in Chrome UI input.  but that means we don't ship any locales at all.  would be nice if we could figure out a way to pull or generate locales on demand, but that requires tools/data files that we don't ship in release images since they add significant overhead.

 Issue 650403  has been merged into this issue.

 Issue 642464  has been merged into this issue.

So this is what triggered the regression?

https://chromium-review.googlesource.com/#/c/368200/

I love the comment here:

https://bugs.chromium.org/p/chromium/issues/detail?id=117330#c43

"assuming it doesn't get reverted, we're good to go :)"

yes, that CL did it.  looks like i need to cleanup the workaround that's in the session manager launcher too:
  https://gerrit.chromium.org/gerrit/17490

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/c0be6d55d5aa9454bd848705dbd7ba27507e76d4

commit c0be6d55d5aa9454bd848705dbd7ba27507e76d4
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu Oct 13 03:31:18 2016

libchromeos-ui: drop LC_ALL env var setting

We no longer create this locale, nor do we use it, so we don't need
to set it either.

BUG= chromium:117330 
BUG= chromium:652326 
TEST=precq still passes

Change-Id: I5afce1359371034a6af483fbf748d055b836be5a
Reviewed-on: https://chromium-review.googlesource.com/397682
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>

[modify] https://crrev.com/c0be6d55d5aa9454bd848705dbd7ba27507e76d4/libchromeos-ui/chromeos/ui/chromium_command_builder.cc
[modify] https://crrev.com/c0be6d55d5aa9454bd848705dbd7ba27507e76d4/libchromeos-ui/chromeos/ui/chromium_command_builder_unittest.cc

should be fairly benign change to merge back

Your change meets the bar and is auto-approved for M55 (branch: 2883)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/1e9c3dac5c903b32026f247e9af1b7fb8d66a069

commit 1e9c3dac5c903b32026f247e9af1b7fb8d66a069
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu Oct 13 03:31:18 2016

libchromeos-ui: drop LC_ALL env var setting

We no longer create this locale, nor do we use it, so we don't need
to set it either.

BUG= chromium:117330 
BUG= chromium:652326 
TEST=precq still passes
(cherry picked from commit c0be6d55d5aa9454bd848705dbd7ba27507e76d4)

Change-Id: I5901f5a2fff9379ec9757811d266e081f4214fea
Reviewed-on: https://chromium-review.googlesource.com/399543
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/1e9c3dac5c903b32026f247e9af1b7fb8d66a069/libchromeos-ui/chromeos/ui/chromium_command_builder.cc
[modify] https://crrev.com/1e9c3dac5c903b32026f247e9af1b7fb8d66a069/libchromeos-ui/chromeos/ui/chromium_command_builder_unittest.cc

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

I guess the auto-labeling features of the merge queue haven't adjusted to our newfangled labeling scheme?

FWIW, no problem:

Version 55.0.2883.17 dev
Platform 8872.15.0

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/99461a21a2193c2afbb2e685f85f7cb3e4dd722f

commit 99461a21a2193c2afbb2e685f85f7cb3e4dd722f
Author: Ilja H. Friedel <ihf@chromium.org>
Date: Wed Oct 26 18:37:40 2016

Revert "libchromeos-ui: drop LC_ALL env var setting"

This reverts commit 1e9c3dac5c903b32026f247e9af1b7fb8d66a069.

For now revert only on R55. For master discussion on  crbug.com/649787 .

BUG= chromium:117330 
BUG= chromium:652326 
BUG= chromium:649787 

Change-Id: I38f752247add52de3d7c02d2ab2a7adf8ee850c3
Reviewed-on: https://chromium-review.googlesource.com/403834
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Bernie Thompson <bhthompson@chromium.org>
Tested-by: Bernie Thompson <bhthompson@chromium.org>

[modify] https://crrev.com/99461a21a2193c2afbb2e685f85f7cb3e4dd722f/libchromeos-ui/chromeos/ui/chromium_command_builder.cc
[modify] https://crrev.com/99461a21a2193c2afbb2e685f85f7cb3e4dd722f/libchromeos-ui/chromeos/ui/chromium_command_builder_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ea9399310a8dcd048442e102f1ad56e8c5367dce

commit ea9399310a8dcd048442e102f1ad56e8c5367dce
Author: Ilja H. Friedel <ihf@chromium.org>
Date: Tue Nov 08 06:22:56 2016

Revert "libchromeos-ui: drop LC_ALL env var setting"

This reverts commit c0be6d55d5aa9454bd848705dbd7ba27507e76d4.

This should fix Facebook games on master.

BUG= chromium:117330 
BUG= chromium:652326 
BUG= chromium:649787 

Change-Id: I160376aa99cb956fa11a1f1c9b265f20fe56771f
Reviewed-on: https://chromium-review.googlesource.com/408818
Commit-Ready: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/ea9399310a8dcd048442e102f1ad56e8c5367dce/libchromeos-ui/chromeos/ui/chromium_command_builder.cc
[modify] https://crrev.com/ea9399310a8dcd048442e102f1ad56e8c5367dce/libchromeos-ui/chromeos/ui/chromium_command_builder_unittest.cc