Verify InspectConstructionArguments returns true when constructing Histogram arguments |
||
Issue descriptionIt was noted in another bug that the return value of InspectConstructionArguments, after being called on a deserialized Histogram, is DCHECKed, potentially causing unexpected behavior in release builds. Since Histograms cross process boundaries the failure condition should be handled explicitly.
,
Oct 5 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 5 2017
InspectConstructionArguments will adjust the values to be acceptable so it's okay to continue even if problems are found. The DCHECK is there to let developers know of the problem before submitting it but since some of these checks came about after a significant number of histograms already existed, it was better to fix rather than crash. Which histograms have bad construction parameters can be followed here: https://uma.googleplex.com/p/chrome/histograms/?endDate=20171003&dayCount=1&histograms=Histogram.BadConstructionArguments&fixupData=true&showMax=true&filters=channel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial With some Canary builds being shipped with DCHECK enabled, I'd hope these would get fixed fairly soon. |
||
►
Sign in to add a comment |
||
Comment 1 by asvitk...@chromium.org
, Oct 4 2016