New issue
Advanced search Search tips

Issue 652314 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 583616



Sign in to add a comment

WebVIew: make spellchecking off by default and opt-in using spellcheck="true" attribute

Project Member Reported by timvolod...@chromium.org, Oct 3 2016

Issue description

Make spellchecking on Android WebView off by default for backward compatibility in apps that use WebView.

Spellchecking can be enabled/disabled explicitly using the spellcheck attribute on spellcheck capable elements (e.g. text <input> elements and elements with the contenteditable="true" attribute)

 
Blocking: 583616
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db1951995f1ce6eb4937f5e431660db383e0ece0

commit db1951995f1ce6eb4937f5e431660db383e0ece0
Author: timvolodine <timvolodine@chromium.org>
Date: Wed Oct 05 13:52:45 2016

[Android WebView] make spellcheck off by default and opt-in using spellcheck="true" attribute.

In WebView no spellchecking will be provided on html elements
unless explicitly enabled via the spellcheck="true" attribute.
The main motivation is to have consistent backward behavior in
apps that use WebView. Also this will benefit performance and
battery life on mobile devices (see  crbug.com/652314 ).

Related blink-side patch:
https://codereview.chromium.org/2316303006/

BUG= 652314 ,  583616 , 629609

Review-Url: https://codereview.chromium.org/2391613002
Cr-Commit-Position: refs/heads/master@{#423147}

[modify] https://crrev.com/db1951995f1ce6eb4937f5e431660db383e0ece0/android_webview/native/aw_settings.cc
[modify] https://crrev.com/db1951995f1ce6eb4937f5e431660db383e0ece0/content/public/common/common_param_traits_macros.h
[modify] https://crrev.com/db1951995f1ce6eb4937f5e431660db383e0ece0/content/public/common/web_preferences.cc
[modify] https://crrev.com/db1951995f1ce6eb4937f5e431660db383e0ece0/content/public/common/web_preferences.h
[modify] https://crrev.com/db1951995f1ce6eb4937f5e431660db383e0ece0/content/renderer/render_view_impl.cc

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db1951995f1ce6eb4937f5e431660db383e0ece0

commit db1951995f1ce6eb4937f5e431660db383e0ece0
Author: timvolodine <timvolodine@chromium.org>
Date: Wed Oct 05 13:52:45 2016

[Android WebView] make spellcheck off by default and opt-in using spellcheck="true" attribute.

In WebView no spellchecking will be provided on html elements
unless explicitly enabled via the spellcheck="true" attribute.
The main motivation is to have consistent backward behavior in
apps that use WebView. Also this will benefit performance and
battery life on mobile devices (see  crbug.com/652314 ).

Related blink-side patch:
https://codereview.chromium.org/2316303006/

BUG= 652314 ,  583616 , 629609

Review-Url: https://codereview.chromium.org/2391613002
Cr-Commit-Position: refs/heads/master@{#423147}

[modify] https://crrev.com/db1951995f1ce6eb4937f5e431660db383e0ece0/android_webview/native/aw_settings.cc
[modify] https://crrev.com/db1951995f1ce6eb4937f5e431660db383e0ece0/content/public/common/common_param_traits_macros.h
[modify] https://crrev.com/db1951995f1ce6eb4937f5e431660db383e0ece0/content/public/common/web_preferences.cc
[modify] https://crrev.com/db1951995f1ce6eb4937f5e431660db383e0ece0/content/public/common/web_preferences.h
[modify] https://crrev.com/db1951995f1ce6eb4937f5e431660db383e0ece0/content/renderer/render_view_impl.cc

Comment 5 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment