Issue metadata
Sign in to add a comment
|
1.6%-20.3% regression in startup.warm.blank_page at 419897:421741 |
||||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Oct 3 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8999809054107400240
,
Oct 3 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8999792095780740656
,
Oct 3 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8999792086683646656
,
Oct 3 2016
Bisect failed: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6741 Failure reason: the build has failed. Additional errors: The metric was not found in the test output. Either of the initial "good" or "bad" revisions failed to be tested or built.
,
Oct 3 2016
=== Auto-CCing suspected CL author sunnyps@chromium.org === Hi sunnyps@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Reland of cc: Remove frame queuing from the scheduler. (patchset #1 id:1 of https://codereview.chromium.org/2336493002/ ) Author : sunnyps Commit description: Reason for revert: Reland after fixing screenshot grabber test and perf issues. Original issue's description: > Revert of cc: Remove frame queuing from the scheduler. (patchset #3 id:40001 of https://codereview.chromium.org/2323063004/ ) > > Reason for revert: > Broke ChromeScreenshotGrabberTest.TakeScreenshot on Linux ChromiumOS Tests (dbg)(1): https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/18015. > > Original issue's description: > > cc: Remove frame queuing from the scheduler. > > > > CC scheduler has a frame queuing mechanism called "retro frames". This > > has been responsible for a lot of complexity and hard to fix bugs. The > > original intent for adding retro frames was to allow the scheduler to > > handle multiple frames in flight but that goal doesn't seem feasible or > > even desirable any more. This CL removes the retro frames queue and > > instead makes the Scheduler end the previous frame when it receives a > > BeginFrame message. > > > > One surprising behavior was that SyntheticBFS MISSED frames would be > > queued as retro frames and this would convert the synchronous begin > > frame call (inside Scheduler::ProcessScheduledActions) to an > > asynchronous retro frame PostTask. To work around this the Scheduler > > keeps track of a single CancelableClosure that's used for MISSED frames. > > > > The above behavior was also causing the BeginFramesNotFromClient tests > > to work even though there was an extra MISSED frame in the queue. This > > is more elegantly solved in another way by using frame number to advance > > the task runner instead of just running pending tasks. > > > > Lastly SchedulerStateMachine is modified so that it's possible to end > > the previous frame and still have the same behavior as before in the > > commit to active tree (browser compositor) mode. > > > > R=brianderson@chromium.org,enne@chromium.org,danakj@chromium.org > > BUG= 602485 , 644992 > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > > > Committed: https://crrev.com/559280b26cc5672f5f054e8ac35281e804c14d78 > > Cr-Commit-Position: refs/heads/master@{#417764} > > TBR=enne@chromium.org,brianderson@chromium.org,danakj@chromium.org,sunnyps@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG= 602485 , 644992 > > Committed: https://crrev.com/95beb47e50065959ee2f5b43cf431431e32e14cd > Cr-Commit-Position: refs/heads/master@{#417895} TBR=enne@chromium.org,brianderson@chromium.org,danakj@chromium.org,sammc@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 602485 , 644992 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2339633003 Cr-Commit-Position: refs/heads/master@{#421268} Commit : 864a70f6f93a87ff374bf2aea2494d4d7d0150d7 Date : Tue Sep 27 18:17:01 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@421256 613.789 4.64889 5 good chromium@421265 613.611 2.88049 5 good chromium@421267 619.211 3.1308 5 good chromium@421268 660.926 2.48391 5 bad <-- chromium@421270 655.884 4.75354 5 bad chromium@421274 655.568 4.63149 5 bad chromium@421292 654.684 4.44449 5 bad Bisect job ran on: mac_10_11_perf_bisect Bug ID: 652304 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests startup.warm.blank_page Test Metric: first_main_frame_load_time/first_main_frame_load_time Relative Change: 6.66% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_11_perf_bisect/builds/943 Job details: https://chromeperf.appspot.com/buildbucket_job_status/8999792095780740656 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5795619115892736 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Oct 4 2016
That CL has been reverted for other reasons. I'll take a look at this too before relanding.
,
Oct 4 2016
,
Oct 4 2016
===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Update fieldtrial_util To Handle Combined Fieldtrial Config Format Author : robliao Commit description: BUG=649363, 650705 Review-Url: https://codereview.chromium.org/2373843002 Cr-Commit-Position: refs/heads/master@{#421670} Commit : 8da8200a279fcafc4a7c68f2e6ef95f4d721bb3a Date : Wed Sep 28 22:51:09 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@421635 211.2 7.32803 5 good chromium@421657 214.0 3.4641 4 good chromium@421668 213.75 7.12641 8 good chromium@421669 217.286 4.0708 7 good chromium@421670 230.625 7.52021 8 bad <-- chromium@421671 229.0 4.30116 5 bad chromium@421674 228.75 8.36233 8 bad chromium@421679 231.75 4.97853 8 bad Bisect job ran on: mac_10_10_perf_bisect Bug ID: 652304 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests tab_switching.five_blank_pages Test Metric: idle_wakeups_total/idle_wakeups_total Relative Change: 9.66% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_bisect/builds/2419 Job details: https://chromeperf.appspot.com/buildbucket_job_status/8999792086683646656 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5862277008326656 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Apr 11 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8982632236772872752 |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by tdres...@chromium.org
, Oct 3 2016