New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 652255 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Crash in base::PersistentMemoryAllocator::AllocateImpl

Project Member Reported by ClusterFuzz, Oct 3 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6269459239272448

Fuzzer: cdiehl_peach
Job Type: linux_asan_chrome_media
Platform Id: linux

Crash Type: UNKNOWN
Crash Address: 0x7f089cf5d0f0
Crash State:
  base::PersistentMemoryAllocator::AllocateImpl
  base::PersistentMemoryAllocator::Allocate
  base::PersistentHistogramAllocator::AllocateHistogram
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_media&range=418222:418375

Minimized Testcase (0.26 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95YychfGjIrijp4FlACk6dFo41L31Q8qSpE5ykj8dgvxmxunD_ThTDd8WnnjTTOMNheS5YUZlTepRLF3wImQCy_mufcllBUxQUMAhob-9J0WMQU7exdBhbIrWoIZukO6ltKN2ft6MKqy2mr2BTSeoqZ2MG6PA?testcase_id=6269459239272448

Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 

Comment 1 by kenrb@chromium.org, Oct 3 2016

Cc: asvitk...@chromium.org
Components: Internals>Metrics
Labels: Pri-1
Owner: bcwh...@chromium.org
Status: Assigned (was: Untriaged)
bcwhite@: This is an ASAN crash showing in PersistentHistogramAllocator, are you able to investigate?
Status: Started (was: Assigned)
Is this reproducable?  I'm running it on my workstation according to the instructions given (I'm new to this), including increasing it to 2500 runs.  No crashes.

I'm not entirely sure I have a correct environment, though.  It says it cannot find some processes but I've installed those packages:

Xvfb: no process found
blackbox: no process found
blackbox: managing screen 0 using TrueColor visual 0x21, depth 24
/etc/X11/blackbox/blackbox-menu: No such file or directory
/home/bcwhite/tmp/asan-linux-release-422171/chrome --user-data-dir=/tmp/tmpQfFFMV/temp/user_profile_0 --log-net-log=/tmp/tmpQfFFMV/temp/net_log_0 --js-flags="--expose-gc --verify-heap" --no-first-run --use-gl=osmesa /home/bcwhite/clusterfuzz/slave-bot/inputs/fuzzer-testcases/fuzz-peach-JPG-230.JPG
Starting run number: 0
Starting run number: 1
Starting run number: 2
Starting run number: 3
Starting run number: 4
Starting run number: 5
Starting run number: 6
Starting run number: 7
Starting run number: 8
Starting run number: 9
Starting run number: 10
Starting run number: 11
Starting run number: 12
Starting run number: 13
Starting run number: 14
Starting run number: 15
Starting run number: 16
Starting run number: 17
Starting run number: 18
Starting run number: 19
Starting run number: 20
Starting run number: 21
Starting run number: 22
Starting run number: 23
Starting run number: 24
No crash found.
XIO:  fatal IO error 11 (Resource temporarily unavailable) on X server ":1"
      after 444 requests (444 known processed) with 0 events remaining.
blackbox: no process found

Project Member

Comment 4 by sheriffbot@chromium.org, Oct 4 2016

Labels: M-55
Project Member

Comment 5 by sheriffbot@chromium.org, Oct 4 2016

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -ReleaseBlock-Beta
This is completely within the control of a Finch experiment so shouldn't block anything.

Could use some help reproducing it, though.
I'm pretty sure that no code changes are responsible for this but rather the CL that enabled testing with the PersistentHistograms feature enabled.

Trying to reproduce it locally.
Project Member

Comment 8 by sheriffbot@chromium.org, Oct 5 2016

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

**** Bulk edit -  please ignore if not applicable ****

This bug  is reported as M55 Beta blocker and we're getting closer to M55 Beta promotion. 
Please plan to have fix ready and merged to M55 branch (2883) by 5:00 PM PT, Monday(10/10) so it has enough baking time in Dev before Beta promotion. Thank you.
I'm unable to produce this on my (Ubuntu) Linux workstation or (Goobuntu) Ubiquity.  It never crashes with the provided build or my own build.  I've used command-line flags and even code changes to ensure that PersistentHistograms are enabled.  Never a crash.

Is it possible that it was a different thread that did the SEGV?

The line in my code that is identified shouldn't cause a crash.  It's a pointer but it's been verified as valid in preceding code so I don't see how it could be out-of-bounds.

If I'm going to investigate further, I'm going to need a way to reproduce it locally or at least get a core dump that I can load into gdb.

If it is assuredly my code causing the crash, the beta-blocker label can be removed since histogram persistence is controlled by an experiment.  I did that once but sheriffbot put it back.

Project Member

Comment 11 by sheriffbot@chromium.org, Oct 13 2016

Labels: -Security_Impact-Head Security_Impact-Beta
Cc: mbarbe...@chromium.org
Labels: -ReleaseBlock-Beta ReleaseBlock-NA
Thanks for digging into this bcwhite@.  mbarbella@, any suggestions?  (Adding ReleaseBlock-NA to stop sheriffbot putting the label back.)
mbarbella, any ideas?
Status: WontFix (was: Started)
This seems no longer reproducible on CF, and we're not seeing any new instances of it. WontFixing.
Project Member

Comment 15 by sheriffbot@chromium.org, Nov 30 2016

Labels: -reward-topanel reward-ineligible
Project Member

Comment 16 by sheriffbot@chromium.org, Mar 9 2017

Labels: -Restrict-View-SecurityTeam allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment