New issue
Advanced search Search tips

Issue 652253 link

Starred by 1 user
Status: Verified
Owner:
chrisha@chromium.org
Closed: Oct 2016
Cc:
gayane@chromium.org
asvitk...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Session.TotalDuration metric has artificial spike at 3 seconds on Windows platform.

Project Member Reported by chrisha@chromium.org, Oct 3 2016 
This is presumably due to the 3 second timeout logic in the ChromeVisibilityObserver, which is not being subtracted from the final reported session duration.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f546cb788ad68d0f2de3ea047a0166a35884b33

commit 8f546cb788ad68d0f2de3ea047a0166a35884b33
Author: chrisha <chrisha@chromium.org>
Date: Mon Oct 03 19:58:55 2016

[DesktopSessionDurationTracker] Remove visibility-switch timeout from session length.

This aims to remove the artificial spike at 3 seconds in the Session.TotalDuration metric.

BUG= 652253 

Review-Url: https://codereview.chromium.org/2385103003
Cr-Commit-Position: refs/heads/master@{#422501}

[modify] https://crrev.com/8f546cb788ad68d0f2de3ea047a0166a35884b33/chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.cc
[modify] https://crrev.com/8f546cb788ad68d0f2de3ea047a0166a35884b33/chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.h
[modify] https://crrev.com/8f546cb788ad68d0f2de3ea047a0166a35884b33/chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer_browsertest.cc
[modify] https://crrev.com/8f546cb788ad68d0f2de3ea047a0166a35884b33/chrome/browser/metrics/desktop_session_duration/desktop_session_duration_tracker.cc
[modify] https://crrev.com/8f546cb788ad68d0f2de3ea047a0166a35884b33/chrome/browser/metrics/desktop_session_duration/desktop_session_duration_tracker.h
[modify] https://crrev.com/8f546cb788ad68d0f2de3ea047a0166a35884b33/chrome/browser/metrics/desktop_session_duration/desktop_session_duration_tracker_unittest.cc

Comment 2 by chrisha@chromium.org, Oct 3 2016

Status: Fixed (was: Started)
Hopefully this is fixed. I'll be monitoring metrics this week to see if the data looks like it makes more sense.

Comment 3 by chrisha@chromium.org, Oct 5 2016

Status: Verified (was: Fixed)
►

Sign in to add a comment