New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 652237 link

Starred by 2 users
Status: Fixed
Owner:
█ miguelg@chromium.org
Last visit > 30 days ago
Closed: Oct 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 571056



Sign in to add a comment

Close XPC process once no alert notifications are displayed

Project Member Reported by miguelg@chromium.org, Oct 3 2016 
Once https://codereview.chromium.org/2070903002 lands we will be keeping a XPC process running all the time once the very first notification of type alert is displayed. We need to make sure it's closed once all notifications of type alert are dismissed.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d624e939a8d3cf2ae751980c5178ff087a7aefba

commit d624e939a8d3cf2ae751980c5178ff087a7aefba
Author: miguelg <miguelg@chromium.org>
Date: Fri Oct 28 17:03:43 2016

Ensure the xpc transaction is ended

This is a best effort activity since there are situations where we cannot
detect that a given alert has been closed. This will however ensure that
1) only one transaction at most is kept opened
2) whenever an alert is detected to be closed end the transaction
if no other alerts are displayed.

BUG= 652237 

Review-Url: https://codereview.chromium.org/2419213003
Cr-Commit-Position: refs/heads/master@{#428397}

[modify] https://crrev.com/d624e939a8d3cf2ae751980c5178ff087a7aefba/chrome/browser/ui/cocoa/notifications/BUILD.gn
[modify] https://crrev.com/d624e939a8d3cf2ae751980c5178ff087a7aefba/chrome/browser/ui/cocoa/notifications/alert_notification_service.h
[modify] https://crrev.com/d624e939a8d3cf2ae751980c5178ff087a7aefba/chrome/browser/ui/cocoa/notifications/alert_notification_service.mm
[modify] https://crrev.com/d624e939a8d3cf2ae751980c5178ff087a7aefba/chrome/browser/ui/cocoa/notifications/notification_service_delegate.mm
[modify] https://crrev.com/d624e939a8d3cf2ae751980c5178ff087a7aefba/chrome/browser/ui/cocoa/notifications/xpc_service_main.mm
[add] https://crrev.com/d624e939a8d3cf2ae751980c5178ff087a7aefba/chrome/browser/ui/cocoa/notifications/xpc_transaction_handler.h
[add] https://crrev.com/d624e939a8d3cf2ae751980c5178ff087a7aefba/chrome/browser/ui/cocoa/notifications/xpc_transaction_handler.mm

Comment 2 by miguelg@chromium.org, Oct 28 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment