Issue metadata
Sign in to add a comment
|
Regression: Browser crash is seen on hitting ctrl+shift+p on NTP |
||||||||||||||||||||||
Issue descriptionVersion: 55.0.2878.0/8858.0.0 dev channel Spring,Gnawty,Wolf OS: Chrome What steps will reproduce the problem? (1)Launch chrome>>Open NTP>>Now hit ctrl+shift+p and observe browser crash. Expected: Browser should not get crashed on hitting ctrl+shift+p on NTP Actual: Instead browser crash is seen. Crash ids: 7277814300000000, d33946ed00000000 This is Regression issue as it is working fine in 53.0.2785.103/8530.81.0 (Official Build) stable-channel veryon_jerry.
,
Oct 3 2016
Issue 651944 has been merged into this issue.
,
Oct 3 2016
Reproduce the issue on Chrome 54.0.2840.45/ CrOS 8743.46.0 -Glimmer Crash ID: 78ef89ed00000000 Thread 70 CRASHED [SIGSEGV @ 0x00007f725f26f7d0 ] MAGIC SIGNATURE THREAD 0x00007f725b7ebaff (libcups.so.2 -http.c:3329 ) httpWrite2 0x00007f725b80e829 (libcups.so.2 -request.c:945 ) cupsWriteRequestData 0x00007f725fa886e5 (chrome -cups_printer.cc:219 ) printing::CupsPrinter::StreamData 0x00007f725fa834b1 (chrome -printing_context_chromeos.cc:395 ) printing::PrintingContextChromeos::StreamData 0x00007f725fa83e1c (chrome -printed_document_chromeos.cc:36 ) printing::PrintedDocument::RenderPrintedPage 0x00007f725e83743e (chrome -print_job_worker.cc:409 ) printing::PrintJobWorker::SpoolPage 0x00007f725e8375e0 (chrome -print_job_worker.cc:327 ) printing::PrintJobWorker::OnNewPage 0x00007f725cfddccb (chrome -callback.h:388 ) base::debug::TaskAnnotator::RunTask 0x00007f725cfc7029 (chrome -message_loop.cc:488 ) base::MessageLoop::DoDelayedWork 0x00007f725cfc7a20 (chrome -message_pump_default.cc:39 ) base::MessagePumpDefault::Run 0x00007f725e922447 (chrome -run_loop.cc:35 ) base::RunLoop::Run 0x00007f725e93818f (chrome -thread.cc:301 ) base::Thread::ThreadMain 0x00007f725e935cb5 (chrome -platform_thread_posix.cc:71 ) ThreadFunc 0x00007f725bc9a306 (libpthread-2.19.so -pthread_create.c:309 ) start_thread 0x00007f725a9b25cc (libc-2.19.so + 0x000f95cc ) clone
,
Oct 3 2016
Issue 651476 has been merged into this issue.
,
Oct 3 2016
CL is being reviewed.
,
Oct 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03b6108c27abe7ebecec0179c34c05938ae3e905 commit 03b6108c27abe7ebecec0179c34c05938ae3e905 Author: skau <skau@chromium.org> Date: Wed Oct 05 01:52:29 2016 Disable Ctrl+Shift+P on Chrome OS Chrome OS uses ENABLE_BASIC_PRINTING but has no system dialog. Disable the shortcut as invoking printing in this state causes a crash. BUG= 652220 TEST=Verify printing still works. Ctrl+Shift+P is a nop. Review-Url: https://codereview.chromium.org/2376193006 Cr-Commit-Position: refs/heads/master@{#423047} [modify] https://crrev.com/03b6108c27abe7ebecec0179c34c05938ae3e905/chrome/browser/ui/browser_commands.cc [modify] https://crrev.com/03b6108c27abe7ebecec0179c34c05938ae3e905/chrome/browser/ui/webui/print_preview/print_preview_handler.cc [modify] https://crrev.com/03b6108c27abe7ebecec0179c34c05938ae3e905/chrome/browser/ui/webui/print_preview/print_preview_handler.h [modify] https://crrev.com/03b6108c27abe7ebecec0179c34c05938ae3e905/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc [modify] https://crrev.com/03b6108c27abe7ebecec0179c34c05938ae3e905/chrome/common/BUILD.gn [modify] https://crrev.com/03b6108c27abe7ebecec0179c34c05938ae3e905/chrome/common/features.gni [modify] https://crrev.com/03b6108c27abe7ebecec0179c34c05938ae3e905/printing/printing_context_chromeos.cc
,
Oct 5 2016
Any pending CL to resolve this beta blocker? skau@ can you merge this to M54?
,
Oct 5 2016
,
Oct 5 2016
No. This is the only CL. Yes, I can merge it into 54.
,
Oct 5 2016
ok, I just approved it so please go ahead and merge to m54 (2840)
,
Oct 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b0d241ad472b161b02867784e52fcad7c5e97f8 commit 5b0d241ad472b161b02867784e52fcad7c5e97f8 Author: skau <skau@chromium.org> Date: Wed Oct 05 19:35:21 2016 Disable Ctrl+Shift+P on Chrome OS Chrome OS uses ENABLE_BASIC_PRINTING but has no system dialog. Disable the shortcut as invoking printing in this state causes a crash. BUG= 652220 TEST=Verify printing still works. Ctrl+Shift+P is a nop. NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2376193006 Cr-Commit-Position: refs/heads/master@{#423047} (cherry picked from commit 03b6108c27abe7ebecec0179c34c05938ae3e905) Review-Url: https://codereview.chromium.org/2398743002 Cr-Commit-Position: refs/branch-heads/2840@{#651} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/5b0d241ad472b161b02867784e52fcad7c5e97f8/chrome/browser/ui/browser_commands.cc [modify] https://crrev.com/5b0d241ad472b161b02867784e52fcad7c5e97f8/chrome/browser/ui/webui/print_preview/print_preview_handler.cc [modify] https://crrev.com/5b0d241ad472b161b02867784e52fcad7c5e97f8/chrome/browser/ui/webui/print_preview/print_preview_handler.h [modify] https://crrev.com/5b0d241ad472b161b02867784e52fcad7c5e97f8/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc [modify] https://crrev.com/5b0d241ad472b161b02867784e52fcad7c5e97f8/chrome/common/BUILD.gn [modify] https://crrev.com/5b0d241ad472b161b02867784e52fcad7c5e97f8/chrome/common/features.gni [modify] https://crrev.com/5b0d241ad472b161b02867784e52fcad7c5e97f8/printing/printing_context_chromeos.cc
,
Oct 10 2016
Verified on build 8872.5.0
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b0d241ad472b161b02867784e52fcad7c5e97f8 commit 5b0d241ad472b161b02867784e52fcad7c5e97f8 Author: skau <skau@chromium.org> Date: Wed Oct 05 19:35:21 2016 Disable Ctrl+Shift+P on Chrome OS Chrome OS uses ENABLE_BASIC_PRINTING but has no system dialog. Disable the shortcut as invoking printing in this state causes a crash. BUG= 652220 TEST=Verify printing still works. Ctrl+Shift+P is a nop. NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2376193006 Cr-Commit-Position: refs/heads/master@{#423047} (cherry picked from commit 03b6108c27abe7ebecec0179c34c05938ae3e905) Review-Url: https://codereview.chromium.org/2398743002 Cr-Commit-Position: refs/branch-heads/2840@{#651} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/5b0d241ad472b161b02867784e52fcad7c5e97f8/chrome/browser/ui/browser_commands.cc [modify] https://crrev.com/5b0d241ad472b161b02867784e52fcad7c5e97f8/chrome/browser/ui/webui/print_preview/print_preview_handler.cc [modify] https://crrev.com/5b0d241ad472b161b02867784e52fcad7c5e97f8/chrome/browser/ui/webui/print_preview/print_preview_handler.h [modify] https://crrev.com/5b0d241ad472b161b02867784e52fcad7c5e97f8/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc [modify] https://crrev.com/5b0d241ad472b161b02867784e52fcad7c5e97f8/chrome/common/BUILD.gn [modify] https://crrev.com/5b0d241ad472b161b02867784e52fcad7c5e97f8/chrome/common/features.gni [modify] https://crrev.com/5b0d241ad472b161b02867784e52fcad7c5e97f8/printing/printing_context_chromeos.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by abodenha@chromium.org
, Oct 3 2016Labels: -ReleaseBlock-Dev ReleaseBlock-Beta
Owner: skau@chromium.org
Status: Assigned (was: Untriaged)