New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 652215 link

Starred by 1 user
Status: Fixed
Owner:
█ emso@chromium.org
Last visit > 30 days ago
Closed: Nov 2017
Cc:
abodenha@chromium.org
j...@chromium.org
flyboy@chromium.org
rauch+monorail-auto@google.com
█ orodley+autocc@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Xrefs for ChromeOS

Project Member Reported by emso@chromium.org, Oct 3 2016 
Display Xrefs for ChromeOS.

There is already a builder for ChromeOS: https://build.chromium.org/p/chromium.infra.cron/builders/ChromiumOS%20Codesearch/

But the compile step is failing and it is unclear if the results are displayed anywhere.

Comment 1 by emso@chromium.org, Oct 3 2016 

Example of Chrome OS specific code:

https://cs.chromium.org/chromium/src/ash/common/system/tray/system_tray.cc?sq=package:chromium&dr=CSs&l=232

This code only compiles on Chrome OS but there are still Xrefs shown in the current version of code search:

https://cs.chromium.org/chromium/src/chromeos/settings/timezone_settings.h?sq=package:chromium&dr=CSs&rcl=1474529952&l=24

Comment 2 by emso@chromium.org, Oct 3 2016

Owner: emso@chromium.org
Status: Assigned (was: Available)

Comment 3 by jamescook@chromium.org, Oct 3 2016

Cc: abodenha@chromium.org
+abodenha FYI - I think this would help your team.

Comment 4 by abodenha@chromium.org, Oct 3 2016 

Immensely!

Comment 5 by emso@chromium.org, Oct 4 2016

Labels: Xrefs

Comment 6 by emso@chromium.org, Oct 10 2016 

Some more input on the current code search behavior for ChromeOS. 

Currently, this filter https://cs.chromium.org/chromium/build/scripts/slave/recipes/chromium_codesearch.py?rcl=0&l=177 filters out ChromeOS Xrefs for files with Linux Xrefs. This is because currently there is no merging of Xrefs. This explains the behavior where there is ChromeOS Xrefs for one file but not another, as long as, the file with the ChromeOS Xrefs is only compiled for ChromeOS.

Comment 7 by emso@chromium.org, Nov 2 2017

Status: Fixed (was: Assigned)
We currently display Xrefs for ChromeOS for files unique to ChromeOS. With the current level of support for displaying Xrefs for multiple configs, this is all way can provide.

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 9 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
►

Sign in to add a comment