Issue metadata
Sign in to add a comment
|
Bad-cast to content::RenderWidgetHostViewChildFrame from content::RenderWidgetHostViewAura |
||||||||||||||||||||||
Issue descriptionDetailed report: https://cluster-fuzz.appspot.com/testcase?key=6650366534090752 Fuzzer: mbarbella_js_mutation_layout Job Type: linux_cfi_chrome Platform Id: linux Crash Type: Bad-cast Crash Address: 0x7feaeb7b2690 Crash State: Bad-cast to content::RenderWidgetHostViewChildFrame from content::RenderWidgetHostViewAura Recommended Security Severity: Medium Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_cfi_chrome&range=418926:419035 Unminimized Testcase: https://cluster-fuzz.appspot.com/download/AMIfv961JqAOaJYuCawRNqA-7ekKhu4GkkCKfqxqtkGn_WbXsng6u9Vleakuoqh3tJ2bCWwEivc3k7i-qf0Z41NFkmy9p6b_UOgukCbz-fW3Dto1xzw7i_oS2zTbxLIIqiJw8IsqNkCF9W_fRQoSoL23Mtw3dL_xmOa8nNdr-Wa0YzBkzF1BfD8?testcase_id=6650366534090752 Additional requirements: Requires Gestures Issue filed automatically. See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
,
Oct 3 2016
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 3 2016
,
Oct 3 2016
Strongly suspecting https://chromium.googlesource.com/chromium/src/+/30d21915acf01e3cb5746b1a3cb2e8786c2bd841 as the regression. I will deal with this when my sheriff rotation ends.
,
Oct 3 2016
Hi kenrb - is there anybody who could take a look while you're sheriffing? We're promoting M55 to Beta this week and this is marked as a blocker for that since it's a regression.
,
Oct 3 2016
I can try to figure this out tomorrow, and worst case I will revert that CL.
,
Oct 4 2016
This shouldn't be a blocker. The problematic code is browser side input event processing, which is not reachable strictly from web content. The need for very specific user interaction is mitigating.
,
Oct 5 2016
,
Oct 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83e4f9ac895d5b42a4b114f3ef964676a40476ff commit 83e4f9ac895d5b42a4b114f3ef964676a40476ff Author: kenrb <kenrb@chromium.org> Date: Tue Oct 11 20:36:27 2016 Clear last MouseMove root view in RWHIER if that view gets destroyed Cluster-fuzz has reported some difficult-to-reproduce crashes in the MouseEnter/Leave generation code in RenderWidgetHostInputEventRouter, and there are some very sparse crash reports appearing for that also. These might be caused by race conditions from RenderWidgetHostView tree modifications that get slightly out of sync from the Surface state that is used for hit testing (Surfaces aren't invalidated until RWHVs are deleted, which for some RWHVs is not immediate upon them having Destroy() called). This CL speculatively tries to address the crashes by having SendMouseEnterOrLeaveEvents abort when it discovers the RWHV tree out of sync, and also clearing last_mouse_move_root_view_ when that gets destroyed. BUG= 647821 , 652209 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2396083002 Cr-Commit-Position: refs/heads/master@{#424533} [modify] https://crrev.com/83e4f9ac895d5b42a4b114f3ef964676a40476ff/content/browser/frame_host/render_widget_host_view_child_frame.cc [modify] https://crrev.com/83e4f9ac895d5b42a4b114f3ef964676a40476ff/content/browser/frame_host/render_widget_host_view_child_frame.h [modify] https://crrev.com/83e4f9ac895d5b42a4b114f3ef964676a40476ff/content/browser/renderer_host/render_widget_host_input_event_router.cc [modify] https://crrev.com/83e4f9ac895d5b42a4b114f3ef964676a40476ff/content/browser/renderer_host/render_widget_host_view_base.cc [modify] https://crrev.com/83e4f9ac895d5b42a4b114f3ef964676a40476ff/content/browser/renderer_host/render_widget_host_view_base.h
,
Oct 13 2016
,
Nov 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/68f883645ff0c2f46fa75128af0642e87e7095bd commit 68f883645ff0c2f46fa75128af0642e87e7095bd Author: Ken Buchanan <kenrb@chromium.org> Date: Thu Nov 03 20:54:24 2016 Clear last MouseMove root view in RWHIER if that view gets destroyed Cluster-fuzz has reported some difficult-to-reproduce crashes in the MouseEnter/Leave generation code in RenderWidgetHostInputEventRouter, and there are some very sparse crash reports appearing for that also. These might be caused by race conditions from RenderWidgetHostView tree modifications that get slightly out of sync from the Surface state that is used for hit testing (Surfaces aren't invalidated until RWHVs are deleted, which for some RWHVs is not immediate upon them having Destroy() called). This CL speculatively tries to address the crashes by having SendMouseEnterOrLeaveEvents abort when it discovers the RWHV tree out of sync, and also clearing last_mouse_move_root_view_ when that gets destroyed. BUG= 647821 , 652209 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2396083002 Cr-Commit-Position: refs/heads/master@{#424533} (cherry picked from commit 83e4f9ac895d5b42a4b114f3ef964676a40476ff) Review URL: https://codereview.chromium.org/2477893002 . Cr-Commit-Position: refs/branch-heads/2883@{#445} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/68f883645ff0c2f46fa75128af0642e87e7095bd/content/browser/frame_host/render_widget_host_view_child_frame.cc [modify] https://crrev.com/68f883645ff0c2f46fa75128af0642e87e7095bd/content/browser/frame_host/render_widget_host_view_child_frame.h [modify] https://crrev.com/68f883645ff0c2f46fa75128af0642e87e7095bd/content/browser/renderer_host/render_widget_host_input_event_router.cc [modify] https://crrev.com/68f883645ff0c2f46fa75128af0642e87e7095bd/content/browser/renderer_host/render_widget_host_view_base.cc [modify] https://crrev.com/68f883645ff0c2f46fa75128af0642e87e7095bd/content/browser/renderer_host/render_widget_host_view_base.h
,
Nov 4 2016
Please mark security bugs as fixed as soon as the fix lands, and before requesting merges. This update is based on the merge- labels applied to this issue. Please reopen if this update was incorrect. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 5 2016
,
Feb 10 2017
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sheriffbot@chromium.org
, Oct 3 2016