New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 652190 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Ripple Effect for 'Overwrite original' checkbox is seen missing in Gallery

Project Member Reported by mmanchala@chromium.org, Oct 3 2016

Issue description

Version : 55.0.2878.0/8858.0.0 
Devices : Wolf,Spring and Gnawty
OS      : Chrome OS

What steps will reproduce the problem?
1.Sign into User -> Download images
2.Now Select one Image and open it in Gallery -> Click on Edit Icon
3.Now try to uncheck and check 'Overwrite original' checkbox and observe for Ripple Effect

Expected: Ripple Effect should be seen On uncheck and checking 'Overwrite original' checkbox 
Actual: Instead Ripple Effect is seen missing

This is a Regression issue as same is working fine in 53.0.2785.103/8530.81.0 stable-channel-Jerry
Issue not applicable to Linux and windows

Note: Issue is also seen on tabbing

Steps:
1)In Gallery -> Click on Edit Icon -> Now click on Tab Button upto 'Overwrite original' checkbox  and observe for ripple effect

@yawano :  Please confirm the issue
 
Actual_Ripple.webm
308 KB View Download
Expected_Rippleeffect.webm
198 KB View Download
Expected_Focus.jpg
37.5 KB View Download
Cc: yawano@chromium.org
Owner: fukino@chromium.org
fukino@: could you take a look at this, or re-assign to the proper owner? Thank you!
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c662b2126f073010eac4fa9a5eec15ea2922afd

commit 2c662b2126f073010eac4fa9a5eec15ea2922afd
Author: fukino <fukino@chromium.org>
Date: Wed Oct 05 08:03:53 2016

Gallery: Set the ripple size of paper-checkbox explicitly.

Due to an issue in Polymer, the ripple size doesn't seems to be calculated properly.
https://github.com/Polymer/polymer/issues/4009
We can work around this issue by setting the ripple size explicitly.

BUG= 652190 
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2388043004
Cr-Commit-Position: refs/heads/master@{#423106}

[modify] https://crrev.com/2c662b2126f073010eac4fa9a5eec15ea2922afd/ui/file_manager/gallery/gallery.html

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on ChromeOS 8872.18.0, 55.0.2883.20

Sign in to add a comment